Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Utopia 1291] check PI PIA to make sure preselect adm role in program area if condition satisify #1386

Merged
merged 10 commits into from
Jul 18, 2023

Conversation

binggaofw
Copy link
Contributor

Description

This PR includes the following proposed change(s):

  • see title
Screenshot 2023-07-14 at 4 21 49 PM

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Documentation
  • Updating Testing Framework(s)
  • Version change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Development Dependency Working Agreement

  • My code DOES NOT include the importing of new dependencies into the DPIA ecosystem
  • My code DOES include the importing of new dependencies into the DPIA ecosystem
    If new dependencies are being introduced to the DPIA ecosystem:
  • The functionality of the dependency drastically reduces code complexity and makes my changes more easily maintainable and readible
  • The dependency being introduced does not contain multiple layers of nested dependencies introducing maintainability complexity to the DPIA ecosystem

Frontend Development Changes

  • N/A
  • I have performed a self-review of my own code
  • I have made corresponding changes to project documentation or diagrams that reflect my changes
  • New and existing unit tests pass locally with my changes
  • My code follows Airbnb React Style Guidelines

API Development Changes

  • N/A
  • I have performed a self-review of my own code
  • My code follows standards and practices outlined in the BC Government API Development Guidelines
  • New and existing unit tests pass locally with my changes
  • My changes includes Swagger documentation updates that reflect the changes I am introducing

Definition of Done

Definition of Done

@github-actions github-actions bot added the DPIA Web App PR contains changes to DPIA frontend app label Jul 15, 2023
Bottle7
Bottle7 previously approved these changes Jul 17, 2023
Comment on lines 103 to 104
!pia?.review?.programArea.selectedRoles.includes(ApprovalRoles.ADM) &&
!reviewForm.programArea?.selectedRoles.includes(ApprovalRoles.ADM)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why checking for both? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!reviewForm.programArea?.selectedRoles.includes(ApprovalRoles.ADM) will move the second check

@binggaofw
Copy link
Contributor Author

Screenshot 2023-07-18 at 2 06 17 PM

@binggaofw binggaofw merged commit 4b04c1d into main Jul 18, 2023
6 checks passed
@binggaofw binggaofw deleted the UTOPIA-1291 branch July 18, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DPIA Web App PR contains changes to DPIA frontend app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants