Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTOPIA-1201: (backend) update endpoints to support Complete status #1411

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

Bottle7
Copy link
Contributor

@Bottle7 Bottle7 commented Jul 21, 2023

Description

This PR includes the following proposed change(s):

  • Extended the PIA return API to show COMPLETE PIAs
    • Only show if COMPLETE status query sent
    • Only show if user is involved in the PIA (drafter, invitee, or MPO)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Documentation
  • Updating Testing Framework(s)
  • Version change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Development Dependency Working Agreement

  • My code DOES NOT include the importing of new dependencies into the DPIA ecosystem
  • My code DOES include the importing of new dependencies into the DPIA ecosystem
    If new dependencies are being introduced to the DPIA ecosystem:
  • The functionality of the dependency drastically reduces code complexity and makes my changes more easily maintainable and readible
  • The dependency being introduced does not contain multiple layers of nested dependencies introducing maintainability complexity to the DPIA ecosystem

Frontend Development Changes

  • N/A
  • I have performed a self-review of my own code
  • I have made corresponding changes to project documentation or diagrams that reflect my changes
  • New and existing unit tests pass locally with my changes
  • My code follows Airbnb React Style Guidelines

API Development Changes

  • N/A
  • I have performed a self-review of my own code
  • My code follows standards and practices outlined in the BC Government API Development Guidelines
  • New and existing unit tests pass locally with my changes
  • My changes includes Swagger documentation updates that reflect the changes I am introducing

Definition of Done

Definition of Done

@Bottle7 Bottle7 requested a review from antsand as a code owner July 21, 2023 17:35
@Bottle7 Bottle7 self-assigned this Jul 21, 2023
@github-actions github-actions bot added the DPIA API PR contains changes to DPIA API label Jul 21, 2023
@Bottle7 Bottle7 changed the title Extended the PIA return API to show COMPLETE PIAs UTOPIA-1201: (backend) update endpoints to support Complete status Jul 21, 2023
Copy link
Contributor

@kushal-arora-fw kushal-arora-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments. + Tests pending to be addressed.

src/backend/src/modules/pia-intake/pia-intake.service.ts Outdated Show resolved Hide resolved
src/backend/src/modules/pia-intake/pia-intake.service.ts Outdated Show resolved Hide resolved
- Only show if COMPLETE status query sent
- Only show if user is involved in the PIA (drafter, invitee, or MPO)
@github-actions github-actions bot added the DPIA Web App PR contains changes to DPIA frontend app label Jul 26, 2023
binggaofw
binggaofw previously approved these changes Jul 26, 2023
- Fix tests
- Fix lint errors
binggaofw
binggaofw previously approved these changes Jul 26, 2023
total: 100,
};
expect(result).toEqual(expectedResult);
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just that if you can create a scenario each for when a user is an MPO, and when they are a CPO?

Copy link
Contributor

@kushal-arora-fw kushal-arora-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Bottle7 Bottle7 merged commit a319f2b into main Jul 27, 2023
10 checks passed
@Bottle7 Bottle7 deleted the utopia-1201 branch July 27, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DPIA API PR contains changes to DPIA API DPIA Web App PR contains changes to DPIA frontend app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants