-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UTOPIA-1308: (backend) add new status #1451
Conversation
do you want to add unit test in a different PR or will add the ut later? |
…a.ts Co-authored-by: kushal-arora-fw <Kushal.Arora1@ca.ey.com>
…a.ts Co-authored-by: kushal-arora-fw <Kushal.Arora1@ca.ey.com>
case SizeEnum.ALL: | ||
if (Array.isArray(value) && value.length > 0) { | ||
return value.every((v) => v.isAcknowledged === true); | ||
} | ||
break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since the case is very specific to v.isAcknowledged
, and not generic, I recommend calling it ALL_ACK
{ | ||
accessType: [UserTypesEnum.CPO], | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt this is true. Any CPO user should not be able to move from Pending Completion to COMPLETE without conditions. Suggested addition of User Types to below conditions. And recommend removing this one.
src/backend/src/modules/pia-intake/metadata/pia-status.metadata.ts
Outdated
Show resolved
Hide resolved
src/backend/src/modules/pia-intake/metadata/pia-status.metadata.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic-o!
|
Description
This PR includes the following proposed change(s):
Type of change
How Has This Been Tested?
Move a new Delegated PIA from 'Incomplete' => 'Complete'
Development Dependency Working Agreement
If new dependencies are being introduced to the DPIA ecosystem:
Frontend Development Changes
API Development Changes
Definition of Done