Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTOPIA-1308: (backend) add new status #1451

Merged
merged 10 commits into from
Aug 9, 2023
Merged

UTOPIA-1308: (backend) add new status #1451

merged 10 commits into from
Aug 9, 2023

Conversation

Bottle7
Copy link
Contributor

@Bottle7 Bottle7 commented Aug 3, 2023

Description

This PR includes the following proposed change(s):

  • CPO can now move a PIA from 'Pending completion' => 'Complete'

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Documentation
  • Updating Testing Framework(s)
  • Version change

How Has This Been Tested?

Move a new Delegated PIA from 'Incomplete' => 'Complete'

Development Dependency Working Agreement

  • My code DOES NOT include the importing of new dependencies into the DPIA ecosystem
  • My code DOES include the importing of new dependencies into the DPIA ecosystem
    If new dependencies are being introduced to the DPIA ecosystem:
  • The functionality of the dependency drastically reduces code complexity and makes my changes more easily maintainable and readible
  • The dependency being introduced does not contain multiple layers of nested dependencies introducing maintainability complexity to the DPIA ecosystem

Frontend Development Changes

  • N/A
  • I have performed a self-review of my own code
  • I have made corresponding changes to project documentation or diagrams that reflect my changes
  • New and existing unit tests pass locally with my changes
  • My code follows Airbnb React Style Guidelines

API Development Changes

  • N/A
  • I have performed a self-review of my own code
  • My code follows standards and practices outlined in the BC Government API Development Guidelines
  • New and existing unit tests pass locally with my changes
  • My changes includes Swagger documentation updates that reflect the changes I am introducing

Definition of Done

Definition of Done

@Bottle7 Bottle7 self-assigned this Aug 3, 2023
@github-actions github-actions bot added the DPIA API PR contains changes to DPIA API label Aug 3, 2023
@bcgov bcgov deleted a comment from github-actions bot Aug 3, 2023
@binggaofw
Copy link
Contributor

do you want to add unit test in a different PR or will add the ut later?

Bottle7 and others added 2 commits August 3, 2023 17:15
…a.ts

Co-authored-by: kushal-arora-fw <Kushal.Arora1@ca.ey.com>
…a.ts

Co-authored-by: kushal-arora-fw <Kushal.Arora1@ca.ey.com>
@bcgov bcgov deleted a comment from github-actions bot Aug 4, 2023
@bcgov bcgov deleted a comment from github-actions bot Aug 4, 2023
@bcgov bcgov deleted a comment from github-actions bot Aug 9, 2023
@bcgov bcgov deleted a comment from github-actions bot Aug 9, 2023
BradyMitch
BradyMitch previously approved these changes Aug 9, 2023
Comment on lines 28 to 32
case SizeEnum.ALL:
if (Array.isArray(value) && value.length > 0) {
return value.every((v) => v.isAcknowledged === true);
}
break;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the case is very specific to v.isAcknowledged, and not generic, I recommend calling it ALL_ACK

Comment on lines 382 to 384
{
accessType: [UserTypesEnum.CPO],
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt this is true. Any CPO user should not be able to move from Pending Completion to COMPLETE without conditions. Suggested addition of User Types to below conditions. And recommend removing this one.

@bcgov bcgov deleted a comment from github-actions bot Aug 9, 2023
@bcgov bcgov deleted a comment from github-actions bot Aug 9, 2023
Copy link
Contributor

@kushal-arora-fw kushal-arora-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic-o!

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

# npm audit report

mockery  *
Severity: critical
mockery is vulnerable to prototype pollution - https://github.com/advisories/GHSA-gmwp-3pwc-3j3g
fix available via `npm audit fix --force`
Will install wdio-cucumberjs-json-reporter@1.0.4, which is a breaking change
node_modules/mockery
  @wdio/cucumber-framework  *
  Depends on vulnerable versions of @cucumber/cucumber
  Depends on vulnerable versions of mockery
  node_modules/@wdio/cucumber-framework
    wdio-cucumberjs-json-reporter  >=1.0.5
    Depends on vulnerable versions of @wdio/cucumber-framework
    node_modules/wdio-cucumberjs-json-reporter

semver  <=5.7.1 || 6.0.0 - 6.3.0 || 7.0.0 - 7.5.1
Severity: moderate
semver vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
semver vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
semver vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
fix available via `npm audit fix --force`
Will install wdio-cucumberjs-json-reporter@1.0.4, which is a breaking change
node_modules/@babel/core/node_modules/semver
node_modules/@babel/helper-compilation-targets/node_modules/semver
node_modules/@babel/helper-create-class-features-plugin/node_modules/semver
node_modules/@babel/helper-create-regexp-features-plugin/node_modules/semver
node_modules/@babel/helper-define-polyfill-provider/node_modules/semver
node_modules/@babel/preset-env/node_modules/semver
node_modules/@jest/core/node_modules/semver
node_modules/babel-plugin-istanbul/node_modules/semver
node_modules/babel-plugin-polyfill-corejs2/node_modules/semver
node_modules/cac/node_modules/semver
node_modules/eslint-config-airbnb-base/node_modules/semver
node_modules/eslint-plugin-jsx-a11y/node_modules/semver
node_modules/eslint-plugin-react/node_modules/semver
node_modules/istanbul-lib-report/node_modules/semver
node_modules/make-dir/node_modules/semver
node_modules/read-pkg-up/node_modules/semver
node_modules/semver
  @cucumber/cucumber  8.0.0-rc.1 - 9.2.0
  Depends on vulnerable versions of semver
  node_modules/@cucumber/cucumber

word-wrap  <1.2.4
Severity: moderate
word-wrap vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-j8xg-fqg3-53r7
fix available via `npm audit fix`
node_modules/word-wrap

6 vulnerabilities (3 moderate, 3 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

@Bottle7 Bottle7 merged commit 821e218 into main Aug 9, 2023
7 of 8 checks passed
@Bottle7 Bottle7 deleted the utopia-1308 branch August 9, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DPIA API PR contains changes to DPIA API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants