Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UTOPIA-966] Alphabetical Ministry Names in Drop Down List #1466

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Conversation

NoorChasib
Copy link
Contributor

Description

This PR includes the following proposed change(s):

  • reordered constants list of ministry names to be in alphabetical order

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Documentation
  • Updating Testing Framework(s)
  • Version change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Development Dependency Working Agreement

  • My code DOES NOT include the importing of new dependencies into the DPIA ecosystem
  • My code DOES include the importing of new dependencies into the DPIA ecosystem
    If new dependencies are being introduced to the DPIA ecosystem:
  • The functionality of the dependency drastically reduces code complexity and makes my changes more easily maintainable and readable
  • The dependency being introduced does not contain multiple layers of nested dependencies introducing maintainability complexity to the DPIA ecosystem

Frontend Development Changes

  • N/A
  • I have performed a self-review of my own code
  • I have made corresponding changes to project documentation or diagrams that reflect my changes
  • New and existing unit tests pass locally with my changes
  • My code follows Airbnb React Style Guidelines

API Development Changes

  • N/A
  • I have performed a self-review of my own code
  • My code follows standards and practices outlined in the BC Government API Development Guidelines
  • New and existing unit tests pass locally with my changes
  • My changes includes Swagger documentation updates that reflect the changes I am introducing

Definition of Done

Definition of Done

@github-actions github-actions bot added the DPIA Web App PR contains changes to DPIA frontend app label Aug 14, 2023
@github-actions
Copy link

# npm audit report

mockery  *
Severity: critical
mockery is vulnerable to prototype pollution - https://github.com/advisories/GHSA-gmwp-3pwc-3j3g
fix available via `npm audit fix --force`
Will install wdio-cucumberjs-json-reporter@1.0.4, which is a breaking change
node_modules/mockery
  @wdio/cucumber-framework  *
  Depends on vulnerable versions of @cucumber/cucumber
  Depends on vulnerable versions of mockery
  node_modules/@wdio/cucumber-framework
    wdio-cucumberjs-json-reporter  >=1.0.5
    Depends on vulnerable versions of @wdio/cucumber-framework
    node_modules/wdio-cucumberjs-json-reporter

semver  <=5.7.1 || 6.0.0 - 6.3.0 || 7.0.0 - 7.5.1
Severity: moderate
semver vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
semver vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
semver vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
fix available via `npm audit fix --force`
Will install wdio-cucumberjs-json-reporter@1.0.4, which is a breaking change
node_modules/@babel/core/node_modules/semver
node_modules/@babel/helper-compilation-targets/node_modules/semver
node_modules/@babel/helper-create-class-features-plugin/node_modules/semver
node_modules/@babel/helper-create-regexp-features-plugin/node_modules/semver
node_modules/@babel/helper-define-polyfill-provider/node_modules/semver
node_modules/@babel/preset-env/node_modules/semver
node_modules/@jest/core/node_modules/semver
node_modules/babel-plugin-istanbul/node_modules/semver
node_modules/babel-plugin-polyfill-corejs2/node_modules/semver
node_modules/cac/node_modules/semver
node_modules/eslint-config-airbnb-base/node_modules/semver
node_modules/eslint-plugin-jsx-a11y/node_modules/semver
node_modules/eslint-plugin-react/node_modules/semver
node_modules/istanbul-lib-report/node_modules/semver
node_modules/make-dir/node_modules/semver
node_modules/read-pkg-up/node_modules/semver
node_modules/semver
  @cucumber/cucumber  8.0.0-rc.1 - 9.2.0
  Depends on vulnerable versions of semver
  node_modules/@cucumber/cucumber

word-wrap  <1.2.4
Severity: moderate
word-wrap vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-j8xg-fqg3-53r7
fix available via `npm audit fix`
node_modules/word-wrap

6 vulnerabilities (3 moderate, 3 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

@github-actions
Copy link

# npm audit report

mockery  *
Severity: critical
mockery is vulnerable to prototype pollution - https://github.com/advisories/GHSA-gmwp-3pwc-3j3g
fix available via `npm audit fix --force`
Will install wdio-cucumberjs-json-reporter@1.0.4, which is a breaking change
node_modules/mockery
  @wdio/cucumber-framework  *
  Depends on vulnerable versions of @cucumber/cucumber
  Depends on vulnerable versions of mockery
  node_modules/@wdio/cucumber-framework
    wdio-cucumberjs-json-reporter  >=1.0.5
    Depends on vulnerable versions of @wdio/cucumber-framework
    node_modules/wdio-cucumberjs-json-reporter

semver  <=5.7.1 || 6.0.0 - 6.3.0 || 7.0.0 - 7.5.1
Severity: moderate
semver vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
semver vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
semver vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
fix available via `npm audit fix --force`
Will install wdio-cucumberjs-json-reporter@1.0.4, which is a breaking change
node_modules/@babel/core/node_modules/semver
node_modules/@babel/helper-compilation-targets/node_modules/semver
node_modules/@babel/helper-create-class-features-plugin/node_modules/semver
node_modules/@babel/helper-create-regexp-features-plugin/node_modules/semver
node_modules/@babel/helper-define-polyfill-provider/node_modules/semver
node_modules/@babel/preset-env/node_modules/semver
node_modules/@jest/core/node_modules/semver
node_modules/babel-plugin-istanbul/node_modules/semver
node_modules/babel-plugin-polyfill-corejs2/node_modules/semver
node_modules/cac/node_modules/semver
node_modules/eslint-config-airbnb-base/node_modules/semver
node_modules/eslint-plugin-jsx-a11y/node_modules/semver
node_modules/eslint-plugin-react/node_modules/semver
node_modules/istanbul-lib-report/node_modules/semver
node_modules/make-dir/node_modules/semver
node_modules/read-pkg-up/node_modules/semver
node_modules/semver
  @cucumber/cucumber  8.0.0-rc.1 - 9.2.0
  Depends on vulnerable versions of semver
  node_modules/@cucumber/cucumber

word-wrap  <1.2.4
Severity: moderate
word-wrap vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-j8xg-fqg3-53r7
fix available via `npm audit fix`
node_modules/word-wrap

6 vulnerabilities (3 moderate, 3 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

@NoorChasib NoorChasib merged commit 5b81fe9 into main Aug 14, 2023
5 of 6 checks passed
@NoorChasib NoorChasib deleted the UTOPIA-966 branch August 14, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DPIA Web App PR contains changes to DPIA frontend app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants