-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved logout implementation #1494
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BradyMitch
requested review from
antsand,
Bottle7,
akroon3r,
NoorChasib and
JieunSon96
as code owners
August 25, 2023 17:22
github-actions
bot
added
DPIA API
PR contains changes to DPIA API
DPIA Web App
PR contains changes to DPIA frontend app
labels
Aug 25, 2023
|
NoorChasib
previously approved these changes
Aug 25, 2023
JieunSon96
previously approved these changes
Aug 25, 2023
|
|
NoorChasib
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the following proposed change(s):
This does not resolve the issue of login/logout.
Marco from SSO team needs this in dev to test.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Development Dependency Working Agreement
If new dependencies are being introduced to the DPIA ecosystem:
Frontend Development Changes
API Development Changes
Definition of Done