Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UTOPIA-1403] MPO Review E2E #1529

Merged
merged 4 commits into from
Sep 8, 2023
Merged

[UTOPIA-1403] MPO Review E2E #1529

merged 4 commits into from
Sep 8, 2023

Conversation

JieunSon96
Copy link
Contributor

Description

This PR includes the following proposed change(s):

  • UTOPIA-1403 Added missing scenery
  • Changed Chromedriver to Firefox because of the Keycloak logout issue
  • Added README.md for running a single feature file

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Documentation
  • Updating Testing Framework(s)
  • Version change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Development Dependency Working Agreement

  • My code DOES NOT include the importing of new dependencies into the DPIA ecosystem
  • My code DOES include the importing of new dependencies into the DPIA ecosystem
    If new dependencies are being introduced to the DPIA ecosystem:
  • The functionality of the dependency drastically reduces code complexity and makes my changes more easily maintainable and readable
  • The dependency being introduced does not contain multiple layers of nested dependencies introducing maintainability complexity to the DPIA ecosystem

Frontend Development Changes

  • N/A
  • I have performed a self-review of my own code
  • I have made corresponding changes to project documentation or diagrams that reflect my changes
  • New and existing unit tests pass locally with my changes
  • My code follows Airbnb React Style Guidelines

API Development Changes

  • N/A
  • I have performed a self-review of my own code
  • My code follows standards and practices outlined in the BC Government API Development Guidelines
  • New and existing unit tests pass locally with my changes
  • My changes includes Swagger documentation updates that reflect the changes I am introducing

Definition of Done

Definition of Done

@github-actions github-actions bot added the DPIA Web App PR contains changes to DPIA frontend app label Sep 7, 2023
2. Use the following command, replacing your-feature-file.feature with the name of the specific feature file you want to run:

```bash
npm run wdio -- --spec ./test/features/featurefiles/e2e/your-feature-file.feature
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! Thanks for adding :)

}

async CheckPara (paragraph) {
async clickCheckboxByName(checkboxName) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably better to do this by Id but this will work for now

Copy link
Contributor

@BradyMitch BradyMitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@JieunSon96 JieunSon96 merged commit 181f678 into main Sep 8, 2023
6 checks passed
@JieunSon96 JieunSon96 deleted the UTOPIA-1403 branch September 8, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DPIA Web App PR contains changes to DPIA frontend app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants