Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UTOPIA-1429] Access link redirects to PIA list #1574

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Conversation

BradyMitch
Copy link
Contributor

Description

This PR includes the following proposed change(s):

UTOPIA-1429

  • Made reusable login function.
  • Added post login redirect url local storage varaible.
  • Added fresh login state local storage variable.
  • Redirects on pia list page if fresh login.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Documentation
  • Updating Testing Framework(s)
  • Version change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Last page on logout is saved as redirect for next login.
Invite link is properly opened after successful login.

Development Dependency Working Agreement

  • My code DOES NOT include the importing of new dependencies into the DPIA ecosystem
  • My code DOES include the importing of new dependencies into the DPIA ecosystem
    If new dependencies are being introduced to the DPIA ecosystem:
  • The functionality of the dependency drastically reduces code complexity and makes my changes more easily maintainable and readable
  • The dependency being introduced does not contain multiple layers of nested dependencies introducing maintainability complexity to the DPIA ecosystem

Frontend Development Changes

  • N/A
  • I have performed a self-review of my own code
  • I have made corresponding changes to project documentation or diagrams that reflect my changes
  • New and existing unit tests pass locally with my changes
  • My code follows Airbnb React Style Guidelines

API Development Changes

  • N/A
  • I have performed a self-review of my own code
  • My code follows standards and practices outlined in the BC Government API Development Guidelines
  • New and existing unit tests pass locally with my changes
  • My changes includes Swagger documentation updates that reflect the changes I am introducing

Definition of Done

Definition of Done

@github-actions github-actions bot added the DPIA Web App PR contains changes to DPIA frontend app label Sep 20, 2023
@BradyMitch BradyMitch merged commit 8eec121 into main Sep 22, 2023
9 of 10 checks passed
@BradyMitch BradyMitch deleted the UTOPIA-1429 branch September 22, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DPIA Web App PR contains changes to DPIA frontend app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants