Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Utopia 769] Updated pia-intake entity and associated JSONB classes and dtos #857

Merged
merged 18 commits into from
Feb 15, 2023

Conversation

kushal-arora-fw
Copy link
Contributor

@kushal-arora-fw kushal-arora-fw commented Feb 14, 2023

Description

This PR includes the following proposed change(s):

Updated pia-intake entity and associated jsonb classes and dtos for

  • collectionUseAndDisclosure
  • StoringPersonalInformation

CollectionUseAndDisclosure empty initial default state. For filled in information, refer Tests.

"collectionUseAndDisclosure": {
    "steps": [],
    "collectionNotice": {
      "drafterInput": null,
      "mpoInput": null
    }
  },

StoringPersonalInformation Empty initial default state. For filled in information, refer Tests.

"storingPersonalInformation": {
    "personalInformation": {
      "storedOutsideCanada": null,
      "whereDetails": null
    },
    "sensitivePersonalInformation": {
      "doesInvolve": null,
      "disclosedOutsideCanada": null
    },
    "disclosuresOutsideCanada": {
      "storage": {
        "sensitiveInfoStoredByServiceProvider": null,
        "serviceProviderList": [],
        "disclosureDetails": null,
        "contractualTerms": null,
      },
      "contract": {
        "relyOnExistingContract": null,
        "enterpriseServiceAccessDetails": null,
      },
      "controls": {
        "unauthorizedAccessMeasures": null,
      },
      "trackAccess": {
        "trackAccessDetails": null,
      },
      "risks": {
        "privacyRisks": [],
      },
    },
  }

securityPersonalInformation: Empty initial default state. For filled in information, refer Tests.

"securityPersonalInformation": {
    "digitalToolsAndSystems": {
      "toolsAndAssessment": {
        "involveDigitalToolsAndSystems": null,
        "haveSecurityAssessment": null
      },
      "storage": {
        "onGovServers": null,
        "whereDetails": null
      }
    },
    "accessToPersonalInformation": {
      "onlyCertainRolesAccessInformation": null,
      "accessApproved": null,
      "useAuditLogs": null,
      "additionalStrategies": null
    }
  }

accuracyCorrectionAndRetention: Empty initial default state. For filled in information, refer Tests.

"accuracyCorrectionAndRetention": {
    "accuracy": {
      "description": null
    },
    "correction": {
      "haveProcessInPlace": null,
      "willDocument": null,
      "willConductNotifications": null
    },
    "retention": {
      "usePIForDecision": null,
      "haveApprovedInfoSchedule": null,
      "describeRetention": null
    }
  }

personalInformationBanks: Empty initial default state. For filled in information, refer Tests.

  "personalInformationBanks": {
    "resultingPIB": {
      "willResultInPIB": null,
      "descriptionInformationType": null,
      "mainMinistryInvolved": null,
      "managingPersonName": null,
      "managingPersonPhone": null
    }
  }

additionalRisks: Empty initial default state. For filled in information, refer Tests.

"additionalRisks": {
    "risks": []
  }

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Documentation
  • Version change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Development Dependency Working Agreement

  • My code DOES NOT include the importing of new dependencies into the DPIA ecosystem
  • My code DOES include the importing of new dependencies into the DPIA ecosystem
    If new dependencies are being introduced to the DPIA ecosystem:
  • The functionality of the dependency drastically reduces code complexity and makes my changes more easily maintainable and readible
  • The dependency being introduced does not contain multiple layers of nested dependencies introducing maintainability complexity to the DPIA ecosystem

Frontend Development Changes

  • N/A
  • I have performed a self-review of my own code
  • I have made corresponding changes to project documentation or diagrams that reflect my changes
  • New and existing unit tests pass locally with my changes
  • My code follows Airbnb React Style Guidelines

API Development Changes

  • N/A
  • I have performed a self-review of my own code
  • My code follows standards and practices outlined in the BC Government API Development Guidelines
  • New and existing unit tests pass locally with my changes
  • My changes includes Swagger documentation updates that reflect the changes I am introducing

Definition of Done

Definition of Done

@github-actions github-actions bot added the DPIA API PR contains changes to DPIA API label Feb 14, 2023
@kushal-arora-fw kushal-arora-fw changed the title [Utopia 769] [Utopia 769] Updated pia-intake entity and associated JSONB classes and dtos Feb 14, 2023
@kushal-arora-fw kushal-arora-fw added the DO NOT MERGE Please don't merge me label Feb 14, 2023
@kushal-arora-fw kushal-arora-fw removed the DO NOT MERGE Please don't merge me label Feb 15, 2023
antsand
antsand previously approved these changes Feb 15, 2023
binggaofw
binggaofw previously approved these changes Feb 15, 2023
binggaofw
binggaofw previously approved these changes Feb 15, 2023
@kushal-arora-fw kushal-arora-fw merged commit 8fc8a0a into main Feb 15, 2023
@kushal-arora-fw kushal-arora-fw deleted the utopia-769 branch February 15, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DPIA API PR contains changes to DPIA API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants