feat: digital credentials decorator #2337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
|
@argush3 The failing tests seem to be unrelated |
argush3
reviewed
Nov 29, 2023
argush3
reviewed
Nov 29, 2023
Signed-off-by: Akiff Manji <amanji@petridish.dev>
|
SonarCloud Quality Gate failed.
|
argush3
approved these changes
Nov 29, 2023
Will take a look at this outside of this PR |
amanji
added a commit
to petridishdev/lear
that referenced
this pull request
Nov 30, 2023
* feat: adds check for digital business card feature Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: better function naming Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: decorator pto protect digital credentials endpoints Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: address code review comments Signed-off-by: Akiff Manji <amanji@petridish.dev> --------- Signed-off-by: Akiff Manji <amanji@petridish.dev>
amanji
added a commit
to petridishdev/lear
that referenced
this pull request
Nov 30, 2023
* feat: adds check for digital business card feature Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: better function naming Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: decorator pto protect digital credentials endpoints Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: address code review comments Signed-off-by: Akiff Manji <amanji@petridish.dev> --------- Signed-off-by: Akiff Manji <amanji@petridish.dev>
argush3
pushed a commit
that referenced
this pull request
Dec 1, 2023
* fix: add role to credential data with tests Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: digital credentials decorator (#2337) * feat: adds check for digital business card feature Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: better function naming Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: decorator pto protect digital credentials endpoints Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: address code review comments Signed-off-by: Akiff Manji <amanji@petridish.dev> --------- Signed-off-by: Akiff Manji <amanji@petridish.dev> * fix: test failures Signed-off-by: Akiff Manji <amanji@petridish.dev> --------- Signed-off-by: Akiff Manji <amanji@petridish.dev>
argush3
pushed a commit
that referenced
this pull request
Dec 4, 2023
* fix: add role to credential data with tests Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: digital credentials decorator (#2337) * feat: adds check for digital business card feature Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: better function naming Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: decorator pto protect digital credentials endpoints Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: address code review comments Signed-off-by: Akiff Manji <amanji@petridish.dev> --------- Signed-off-by: Akiff Manji <amanji@petridish.dev> * fix: test failures Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: update message for admin revocation Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: temporarily remove admin revoke updates --------- Signed-off-by: Akiff Manji <amanji@petridish.dev>
argush3
pushed a commit
that referenced
this pull request
Dec 4, 2023
* fix: add role to credential data with tests Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: digital credentials decorator (#2337) * feat: adds check for digital business card feature Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: better function naming Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: decorator pto protect digital credentials endpoints Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: address code review comments Signed-off-by: Akiff Manji <amanji@petridish.dev> --------- Signed-off-by: Akiff Manji <amanji@petridish.dev> * fix: test failures Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: update message for admin revocation Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: temporarily remove admin revoke updates * Revert "chore: temporarily remove admin revoke updates" This reverts commit 77cf97a. --------- Signed-off-by: Akiff Manji <amanji@petridish.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#18688
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).