feat: digital credentials add admin revocation message #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akiff Manji <amanji@petridish.dev>
* feat: adds check for digital business card feature Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: better function naming Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: decorator pto protect digital credentials endpoints Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: address code review comments Signed-off-by: Akiff Manji <amanji@petridish.dev> --------- Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
|
That lint failure is because the legal_api upstream doesn't have the updated enum. Should that be updated separately? |
yeah, can you just do a separate PR for the legal api change first? that we can verify the entity-dc tests too in the 2nd PR |
severinbeauvais
approved these changes
Dec 1, 2023
amanji
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
severinbeauvais
approved these changes
Dec 4, 2023
argush3
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#18521
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).