Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18495 - Add Missing Memorandum PDF to Emailer #2358

Merged
merged 2 commits into from
Dec 14, 2023
Merged

18495 - Add Missing Memorandum PDF to Emailer #2358

merged 2 commits into from
Dec 14, 2023

Conversation

Jxio
Copy link
Collaborator

@Jxio Jxio commented Dec 13, 2023

Issue #: /bcgov/entity18495

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@Jxio Jxio added the bug Something isn't working label Dec 13, 2023
@Jxio Jxio self-assigned this Dec 13, 2023
@Jxio Jxio marked this pull request as draft December 13, 2023 23:40
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #2358 (2f67820) into main (79511cd) will decrease coverage by 6.97%.
Report is 54 commits behind head on main.
The diff coverage is 57.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2358      +/-   ##
==========================================
- Coverage   77.37%   70.41%   -6.97%     
==========================================
  Files         202       26     -176     
  Lines       11602     1531   -10071     
  Branches     1961      229    -1732     
==========================================
- Hits         8977     1078    -7899     
+ Misses       2043      378    -1665     
+ Partials      582       75     -507     
Flag Coverage Δ
entityemailer 70.41% <57.05%> (?)
entityfiler ?
legalapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rvices/entity-emailer/src/entity_emailer/config.py 100.00% <100.00%> (ø)
...mailer/email_processors/correction_notification.py 76.41% <100.00%> (ø)
...iler/src/entity_emailer/message_tracker/tracker.py 83.96% <100.00%> (ø)
...vices/entity-emailer/src/entity_emailer/version.py 100.00% <100.00%> (ø)
...iler/email_processors/special_resolution_helper.py 69.64% <0.00%> (ø)
...rvices/entity-emailer/src/entity_emailer/worker.py 68.61% <0.00%> (ø)
...ler/email_processors/agm_extension_notification.py 65.38% <65.38%> (ø)
...ail_processors/agm_location_change_notification.py 65.38% <65.38%> (ø)
...entity_emailer/email_processors/nr_notification.py 69.23% <36.66%> (ø)

... and 219 files with indirect coverage changes

@Jxio Jxio marked this pull request as ready for review December 14, 2023 00:12
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@JazzarKarim JazzarKarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jxio Jxio merged commit e1a236f into bcgov:main Dec 14, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants