Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18495 - Add Missing Memorandum PDF to Emailer #2358

Merged
merged 2 commits into from
Dec 14, 2023
Merged

18495 - Add Missing Memorandum PDF to Emailer #2358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6991fe6
add missing memorandum pdf to emailer
Jxio Dec 13, 2023
2f67820
lint fix
Jxio Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion legal-api/src/legal_api/core/filing_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def is_special_resolution_correction_by_filing_json(filing: Dict):
# Note this relies on the filing data once. This is acceptable inside of the filer (which runs once)
# and emailer (runs on PAID which is before the filer and runs on COMPLETED).
# For filing data that persists in the database, attempt to use the meta_data instead.
sr_correction_keys = ['rulesInResolution', 'resolution', 'rulesFileKey', 'rulesMemorandumKey',
sr_correction_keys = ['rulesInResolution', 'resolution', 'rulesFileKey', 'memorandumFileKey',
'memorandumInResolution', 'cooperativeAssociationType']
for key in sr_correction_keys:
if key in filing.get('correction'):
Expand Down
2 changes: 1 addition & 1 deletion queue_services/entity-emailer/src/entity_emailer/email_processors/correction_notification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def _get_pdfs(
attach_order += 1
elif is_cp_special_resolution:
rules_changed = bool(filing.filing_json['filing']['correction'].get('rulesFileKey'))
memorandum_changed = bool(filing.filing_json['filing']['correction'].get('rulesMemorandumKey'))
memorandum_changed = bool(filing.filing_json['filing']['correction'].get('memorandumFileKey'))
pdfs = get_completed_pdfs(token, business, filing, name_changed,
rules_changed=rules_changed, memorandum_changed=memorandum_changed)
return pdfs
Expand Down
2 changes: 1 addition & 1 deletion queue_services/entity-emailer/src/entity_emailer/email_templates/CP-SR-CRCTN-COMPLETED.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
{% if filing['rulesFileKey'] %}
<li>Certified Rules</li>
{% endif %}
{% if filing['rulesMemorandumKey'] %}
{% if filing['memorandumFileKey'] %}
<li>Certified Memorandum</li>
{% endif %}
</ul>
Expand Down
Loading