Fix 24073 - validate date and handle time offset #3050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
legal-api/src/legal_api/services/filings/validations/continuation_in.py
Outdated
Show resolved
Hide resolved
| 'error': ( | ||
| f"Founding date does not match with founding date from Colin. " | ||
| f"Filing founding_date: {founding_date}, " | ||
| f"Colin API founding_date: {response_json['business']['foundingDate']}" |
There was a problem hiding this comment.
Yes, thanks for removing the debugging code.
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
vysakh-menon-aot
approved these changes
Oct 30, 2024
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
severinbeauvais
approved these changes
Oct 30, 2024
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
|
|
@vysakh-menon-aot @severinbeauvais |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#24073
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).