Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 24073 - validate date and handle time offset #3050

Merged
merged 7 commits into from
Oct 30, 2024
Merged

Fix 24073 - validate date and handle time offset #3050

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
aa5f11f
validate date and handle time offset
ArwenQin Oct 30, 2024
727e0c2
add unit test - matching dates
ArwenQin Oct 30, 2024
ee631c0
validate date and handle time offset 2
ArwenQin Oct 30, 2024
5d12437
fix lint
ArwenQin Oct 30, 2024
f58b2a9
fix lint 2
ArwenQin Oct 30, 2024
e4c2e3f
update the founding date validation
ArwenQin Oct 30, 2024
e919cb6
fix a typo
ArwenQin Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions legal-api/src/legal_api/services/filings/validations/continuation_in.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
)
from legal_api.services.utils import get_bool, get_str
from legal_api.utils.datetime import datetime as dt
import pytz


def validate(filing_json: dict) -> Optional[Error]: # pylint: disable=too-many-branches;
Expand Down Expand Up @@ -200,13 +201,10 @@ def validate_business_in_colin(filing_json: dict, filing_type: str) -> list:
'path': business_founding_date_path
})
else:
if dt.fromisoformat(founding_date) != dt.fromisoformat(response_json['business']['foundingDate']):
utc = pytz.timezone('UTC')
if dt.fromisoformat(founding_date).astimezone(utc).date() != dt.fromisoformat(response_json['business']['foundingDate']).astimezone(utc).date():
severinbeauvais marked this conversation as resolved.
Show resolved Hide resolved
msg.append({
'error': (
f"Founding date does not match with founding date from Colin. "
f"Filing founding_date: {founding_date}, "
f"Colin API founding_date: {response_json['business']['foundingDate']}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for removing the debugging code.

),
'path': business_founding_date_path
'error': 'Founding date does not match with founding date from Colin.',
'path': business_founding_date_path
})
return msg
Loading