Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24131 - Fix Director Change Output #3059

Merged

Conversation

ArwenQin
Copy link
Collaborator

@ArwenQin ArwenQin commented Nov 5, 2024

Issue #: /bcgov/entity#24131

Description of changes:

  • Allow more company types to have effective date before payment date

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
@vysakh-menon-aot
Copy link
Collaborator

@ArwenQin can you fix the test

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Copy link

sonarqubecloud bot commented Nov 5, 2024

Copy link
Collaborator

@ketaki-deodhar ketaki-deodhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ArwenQin
Copy link
Collaborator Author

ArwenQin commented Nov 5, 2024

@severinbeauvais @vysakh-menon-aot
I just fixed the unit test. Could you please merge it? Thanks!

@vysakh-menon-aot vysakh-menon-aot merged commit ac49622 into bcgov:main Nov 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants