Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24131 - Fix Director Change Output #3059

Merged
merged 4 commits into from
Nov 5, 2024
Merged

24131 - Fix Director Change Output #3059

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
756e029
handle more company types
ArwenQin Nov 5, 2024
541dff8
handle more company types 2
ArwenQin Nov 5, 2024
d46f1d6
fix unit test
ArwenQin Nov 5, 2024
a142255
fix unit test 2
ArwenQin Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions legal-api/src/legal_api/models/filing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,9 +740,9 @@ def set_processed(self, business_type):
self.effective_date = self.payment_completion_date

def effective_date_can_be_before_payment_completion_date(self, business_type):
"""For AR or COD filings on CP or BEN then the effective date can be before the payment date."""
"""For AR or COD filings then the effective date can be before the payment date."""
return self.filing_type in (Filing.FILINGS['annualReport'].get('name'),
Filing.FILINGS['changeOfDirectors'].get('name')) and business_type in {'CP', 'BEN'}
Filing.FILINGS['changeOfDirectors'].get('name'))
severinbeauvais marked this conversation as resolved.
Show resolved Hide resolved

@staticmethod
def _raise_default_lock_exception():
Expand Down
Loading