-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use API in front-end to get list of applications #1145
Comments
Since I am replacing the way getting the applications, I also added this to be convenient/and obvious to user profile to know the user's level of admins like this. It is just a quick addition. If requires, we can have improvement ticket to make it better. |
For this ticket, I think we won't do the last check However, I think we probably miss one ticket to implement backend check (for |
Hi Ian, I wonder if we can mock the famLoginUser access to have delegated admin and test the dropdown has the application the user delegated for? Thanks!! And I'm not sure I understand the second question, maybe we can chat more tomorrow, thanks so much!! |
Encounter an issue when writing tests to verify the dropdown options. Somehow in our test, when we render the manage permission page and try to click and open the dropdown option panel, the dropdown panel can't be found. I submitted an issue in the Primevue GitHub, issue number 5347, will follow up if hear anything from them. Will close this ticket for now, as the main code change is merged, just left the test code, we can create a new ticket to write the test once we hear back from the Primevue team. The test code is in Ian's branch feat/1145-tests. Also put the sample testing code here:
|
Describe the task
Use API cached results in front-end to get list of applications
Acceptance Criteria
Additional context
Refers to the endpoint done in #1144
Story: The UI should use the new get_my_FAM_access API for determining what the user has access to do as a FAM admin or app admin.
May need to do 'manual' testing and separate ticket for component testing if it gets too complicated
Test note:
In ticket #1144, we cached the user access in the local storage "famLoginUser" (this could change depends on how #1144 is implemented). When we write component tests in this ticket, we can set the local storage "famLoginUser" with the access we want (based on different test scenario), and mount the "Manage Application" component, and verify if the dropdown returns the expected applications. Like in the screenshot below, the user has access in three applications, no matter the detail, the dropdown should return three apps.
The text was updated successfully, but these errors were encountered: