feat: #846 user information card new design style

[J0taFerreira]

• user Identity card are now using the new design

some styling is on the common repo.

[ianliuwk1019]

The PR title seems to be wrong at the ticket number (feat: #841).

[ianliuwk1019]

Just quickly look at it, will check later.
But where are the first name and last name?
Or is the scope being reduced? My initially understanding is this might depend on backend change.

[J0taFerreira]

The PR title seems to be wrong at the ticket number (feat: #841).

it was, thanks for noticing

[MCatherine1994]

Just quickly look at it, will check later.
But where are the first name and last name?
Or is the scope being reduced? My initially understanding is this might depend on backend change.

Hi Ian, we have another ticket https://app.zenhub.com/workspaces/fsa-fingerprint-61f04f08304d3e001a4f2578/issues/gh/bcgov/nr-fam-idim-lookup-proxy/40 to let IDIM proxy return these information, maybe we work on the frontend and backend detail later once we have the data?

[ianliuwk1019]

Just quickly look at it, will check later.
But where are the first name and last name?
Or is the scope being reduced? My initially understanding is this might depend on backend change.

Hi Ian, we have another ticket https://app.zenhub.com/workspaces/fsa-fingerprint-61f04f08304d3e001a4f2578/issues/gh/bcgov/nr-fam-idim-lookup-proxy/40 to let IDIM proxy return these information, maybe we work on the frontend and backend detail later once we have the data?

Thank you very much @MCatherine1994 !! Sounds good, I see and understand the new ticket.

• Then I think (nr-fam-idim-lookup-proxy/40 is not difficult) and for this ticket frontend can still have "First Name" and "Last Name" in the table columns as ticket (Figma) intended but for missing values (from new ticket nr-fam-idim-lookup-proxy/40) we can use "N/A" for now (it will only be temporary for few days in main branch). So this ticket can still be done but will need to be released together with ticket nr-fam-idim-lookup-proxy/40.
• In ticket nr-fam-idim-lookup-proxy/40 we can consider include fam backend (not the proxy repo) change to return correct results set for frontend. This also includes update client-code-gen for Swagger (OpenAPI).
  

[ianliuwk1019]

Maybe next time, but the branch name is missing "/":

[ianliuwk1019]

Interesting.... I am seeing this:

Is it because style is on common repo again, that's why I see distorted card?

[MCatherine1994]

Tested with the latest shared stylesheet in the common theme repo, looks good. Chatted with Ian, create a follow up ticket #921 to implement first name, last name frontend and backend code. This one should be good to merge.

[ianliuwk1019]

Tested with the latest shared stylesheet in the common theme repo, looks good. Chatted with Ian, create a follow up ticket #921 to implement first name, last name frontend and backend code. This one should be good to merge.

Thank you Catherine! Feel free to approve it and merge.