Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend minor adjustment #897

Closed
5 tasks done
MCatherine1994 opened this issue Sep 18, 2023 · 2 comments · Fixed by #914
Closed
5 tasks done

Frontend minor adjustment #897

MCatherine1994 opened this issue Sep 18, 2023 · 2 comments · Fixed by #914
Assignees

Comments

@MCatherine1994
Copy link
Contributor

MCatherine1994 commented Sep 18, 2023

Description
Some small frontend adjustment make the UI looks better

Acceptance Criteria

  • Check and update the font size on the manage permission page to match the design, for example the font size of the menu bar is 12, but it's 14 in the UI mockup


  • Confirm with @OlgaLiber2 and Alison, if this "Add user permission" button looks too large? And its border-radius will show some tiny space around, do we want to get rid of the border-radius for this button?
    Update: keep the button size, remove the border-radius for this specific button
    Private Zenhub Image


  • Confirm with @OlgaLiber2 and Alison, if the height of the table header is too much? maybe we can reduce the height a bit?
    Update: no need to change the header height
    Private Zenhub Image

  • The search input has a tiny space below (maybe no need to adjust this if we reduce the "Add user permission" button size)
    Update: solved in Jota's pr feat: #846 user information card new design style #913
    Private Zenhub Image


  • When click on the "Add user permission" button, the border effect doesn't look right
    Private Zenhub Image

@MCatherine1994 MCatherine1994 changed the title Frontend: check font size for the menu side bar and the manage permission page Frontend minor adjustment Sep 19, 2023
@OlgaLiber2
Copy link
Collaborator

@MCatherine1994 on your first point about the font size, we are using the "body-compact-01" style. It's is 14px. Please cross reference with the design system and make it agnostic to the component. Let me know if you need me to show you.

"user permissions" button needs to stretch for visibility and works with the design of the table. It was user tested and we have positive feedback from on usability. I don't think the button in our designs has a border.

Keep height of the table as it is in the Figma mockups.

adjust the space below the search to eliminate it.

Yes, border effect on the button needs to be removed. Can you check the button behaviour with SPAR?

@MCatherine1994 MCatherine1994 self-assigned this Sep 20, 2023
MCatherine1994 added a commit that referenced this issue Sep 21, 2023
- add button on focus effect for landing button as it cannot apply the shared style
- update fontsize in side nav, and change the unit from px to rem
- remove the border radius for the speific add user permission button

refs: #897
MCatherine1994 added a commit that referenced this issue Sep 21, 2023
- fix user data table background height problem
refs: #897
@MCatherine1994
Copy link
Contributor Author

Fix the manage permission screen table background height issue as well, when screen size is small, the background color doesn't look right

Private Zenhub Image
Private Zenhub Image

MCatherine1994 added a commit that referenced this issue Sep 21, 2023
- remove unused classname
- update nr-theme package to latest
refs: #897
MCatherine1994 added a commit that referenced this issue Sep 21, 2023
…agement into fix/897-fontend-style

fix(897):
- merge from main
- fix input height problem, some style is in the common theme repo
refs: #897
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants