-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend minor adjustment #897
Comments
@MCatherine1994 on your first point about the font size, we are using the "body-compact-01" style. It's is 14px. Please cross reference with the design system and make it agnostic to the component. Let me know if you need me to show you. "user permissions" button needs to stretch for visibility and works with the design of the table. It was user tested and we have positive feedback from on usability. I don't think the button in our designs has a border. Keep height of the table as it is in the Figma mockups. adjust the space below the search to eliminate it. Yes, border effect on the button needs to be removed. Can you check the button behaviour with SPAR? |
Fix the manage permission screen table background height issue as well, when screen size is small, the background color doesn't look right |
Description
Some small frontend adjustment make the UI looks better
Acceptance Criteria
Check and update the font size on the manage permission page to match the design, for example the font size of the menu bar is 12, but it's 14 in the UI mockup
Confirm with @OlgaLiber2 and Alison, if this "Add user permission" button looks too large? And its border-radius will show some tiny space around, do we want to get rid of the border-radius for this button?
Update: keep the button size, remove the border-radius for this specific button
Private Zenhub Image
Confirm with @OlgaLiber2 and Alison, if the height of the table header is too much? maybe we can reduce the height a bit?
Update: no need to change the header height
Private Zenhub Image
The search input has a tiny space below (maybe no need to adjust this if we reduce the "Add user permission" button size)
Update: solved in Jota's pr feat: #846 user information card new design style #913
Private Zenhub Image
When click on the "Add user permission" button, the border effect doesn't look right
Private Zenhub Image
The text was updated successfully, but these errors were encountered: