Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #897 frontend minor style changes #914

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Conversation

MCatherine1994
Copy link
Contributor

@MCatherine1994 MCatherine1994 commented Sep 21, 2023

Fix #897:

  • update fontsize in side nav, and change the unit from px to rem
  • remove the border radius for the speific add user permission button
  • fix user data table background height problem
  • update to use the latest nr-theme package
  • remove unused class name

Style changes for button on focus is in the shared stylesheet

- add button on focus effect for landing button as it cannot apply the shared style
- update fontsize in side nav, and change the unit from px to rem
- remove the border radius for the speific add user permission button

refs: #897
- fix user data table background height problem
refs: #897
J0taFerreira
J0taFerreira previously approved these changes Sep 21, 2023
Copy link
Contributor

@J0taFerreira J0taFerreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything is working fine!

@ianliuwk1019
Copy link
Collaborator

ianliuwk1019 commented Sep 21, 2023

Hi Catherine, thanks for resolving these minor adjustment we discussed last time.
Maybe this one can adjust a little more (not sure if it is my local issue):
image

May also reduce table margin to the top of background to be equal. Thanks.:
image

@MCatherine1994
Copy link
Contributor Author

Hi Catherine, thanks for resolving these minor adjustment we discussed last time. Maybe this one can adjust a little more (not sure if it is my local issue): image

May also reduce table margin to the top of background to be equal. Thanks.: image

Hi Ian, the input height fix is done in the shared stylesheet, will publish a new version and import again later. The table margin is like that in the design, but I saw next version the margin will be reduced when we add tap, maybe we can change when work on the next version.

@ianliuwk1019
Copy link
Collaborator

Hi Catherine, thanks for resolving these minor adjustment we discussed last time. Maybe this one can adjust a little more (not sure if it is my local issue): image

May also reduce table margin to the top of background to be equal. Thanks.: image

I see, I am confused what style in where but other than that sounds good. Thanks.

ianliuwk1019
ianliuwk1019 previously approved these changes Sep 21, 2023
- remove unused classname
- update nr-theme package to latest
refs: #897
ianliuwk1019
ianliuwk1019 previously approved these changes Sep 21, 2023
…agement into fix/897-fontend-style

fix(897):
- merge from main
- fix input height problem, some style is in the common theme repo
refs: #897
@MCatherine1994
Copy link
Contributor Author

We still left some minor style changes (button on focus effect, input height) in the common theme repo, but those are really tiny ones, we could wait to release the new theme version later.

@MCatherine1994 MCatherine1994 merged commit 2a2a291 into main Sep 26, 2023
8 checks passed
@MCatherine1994 MCatherine1994 deleted the fix/897-fontend-style branch September 26, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend minor adjustment
3 participants