Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature add margin spacing support #82

Merged
merged 5 commits into from
Apr 9, 2019
Merged

Feature add margin spacing support #82

merged 5 commits into from
Apr 9, 2019

Conversation

perber
Copy link

@perber perber commented Apr 6, 2019

Checklist
Ensure all of these are completed before opening the PR:

Describe the changes
Added support for margin and spacing

Closing issues
Resolves #59

@perber perber requested a review from bcvery1 as a code owner April 6, 2019 22:35
@bcvery1
Copy link
Owner

bcvery1 commented Apr 8, 2019

It looks like this is failing for older versions of Go. This may just be a Travis issue

@bcvery1 bcvery1 added this to the v0.4.0 release milestone Apr 8, 2019
@bcvery1
Copy link
Owner

bcvery1 commented Apr 8, 2019

@perber I'm happy to merge this once tests are passing. I'll take a look at the reason behind the failure when I can, but if you think you can figure it out, please go ahead

@bcvery1 bcvery1 closed this Apr 8, 2019
@bcvery1 bcvery1 reopened this Apr 8, 2019
@perber
Copy link
Author

perber commented Apr 8, 2019

@bcvery1 I will take a look at the travis issue.

@perber
Copy link
Author

perber commented Apr 8, 2019

Hi,
golang/go#31293

There are two possible solutions. Stick to previous go version, than the builds will be successuful or update to a new ubuntu distro. I would prefer to update to a new distribution.

Edit:
I`ve changed the travis.yml file to use the newer xenial distro

@bcvery1
Copy link
Owner

bcvery1 commented Apr 9, 2019

Yeah, I agree that the change in distro is the best choice here. Thanks for taking the time to look further into this issue than was the scope of the original issue!

I'll merge this now

@bcvery1 bcvery1 merged commit 3154756 into bcvery1:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants