Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic if ignore path or file does not exist #91

Closed
nuke-web3 opened this issue Jun 11, 2024 · 0 comments · Fixed by #92
Closed

Panic if ignore path or file does not exist #91

nuke-web3 opened this issue Jun 11, 2024 · 0 comments · Fixed by #92

Comments

@nuke-web3
Copy link
Contributor

Describe the bug

mlc 1.71 panics for ignore-path = [""] or in any case a file does not exist like ignore-path = ["node_modules", "html-slides", "html-book"] (for me these are build artifacts, should be .gitignore respected?)

To Reproduce
Steps to reproduce the behavior:

  1. https://github.com/nuke-web3/book/actions/runs/9467833203/job/26082787141 see the log and workflow file used plus this config

Expected behavior
If a file or path does not exist, it is simply skipped.

Ideally this would use a glob match, but that can be a separate feat req 😀 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant