Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't panic if ignore path not found #91 #92

Merged
merged 1 commit into from
Jun 23, 2024
Merged

fix: don't panic if ignore path not found #91 #92

merged 1 commit into from
Jun 23, 2024

Conversation

nuke-web3
Copy link
Contributor

@nuke-web3 nuke-web3 commented Jun 11, 2024 •
edited
Loading

Closes #91

If approved:

  • bump patch version & release? (can bump in this PR)
  • github action version needs a bump? (I wanna use this in CI ASAP once merged)

@becheran
Copy link
Owner

I see the pain. True. I don't think that a panic is needed here and printing a warning as you did is just fine.

See also this PR for .gitignore file support: #94 (review)

Think that is even more elegant

@becheran becheran merged commit cc10bf3 into becheran:master Jun 23, 2024
6 checks passed
@becheran
Copy link
Owner

Released with 0.17.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic if ignore path or file does not exist
2 participants
@nuke-web3 @becheran