Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph images flicker on gallery screen #43

Closed
andrewpbrett opened this issue May 7, 2020 · 3 comments · Fixed by #103
Closed

Graph images flicker on gallery screen #43

andrewpbrett opened this issue May 7, 2020 · 3 comments · Fixed by #103
Assignees
Labels
BUG Opposite of feature UVI Will count as a User-Visible Improvement zap (closed as) Fixed / completed
Milestone

Comments

@andrewpbrett
Copy link
Contributor

andrewpbrett commented May 7, 2020

Reseminata

From the gallery screen, go into a goal, and then back to the gallery screen.
Or, alternatively, pull to refresh your goals

Expectata

Only graphs that have changed should update

Resultata

Every single graph briefly flickers the placeholder bee image.

@andrewpbrett andrewpbrett added the BUG Opposite of feature label May 7, 2020
@krugerk
Copy link
Contributor

krugerk commented Jun 26, 2020

I have noticed this as well.

It happens because
a) all goals are fetched each time goal gallery is loaded (whether or not there have been any updates)
b) each request for a thumbnail uses the "cache buster" URL, each of which is unique. From the looks of it, the image thus is not cached locally by AlamofireImage.

I am working on a solution for this.

@krugerk
Copy link
Contributor

krugerk commented Jul 4, 2020

The screenshots in the google play store for the android Beeminder app show an option for setting the interval at which the app will check for updated graphs.
It not clear to me how up-to-date those images are.
Nonetheless, is such a setting along a direction in which this app should be headed?

@dreeves
Copy link
Member

dreeves commented Jul 5, 2020

Negative, the plan is to remove that setting from Beedroid. Anti-Settings Principle!

@krugerk krugerk added the UVI Will count as a User-Visible Improvement label Jul 10, 2020
@krugerk krugerk linked a pull request Jul 29, 2020 that will close this issue
@krugerk krugerk self-assigned this Aug 8, 2020
@krugerk krugerk added this to the 5.7 milestone Aug 8, 2020
@dreeves dreeves added the zap (closed as) Fixed / completed label Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Opposite of feature UVI Will count as a User-Visible Improvement zap (closed as) Fixed / completed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants