segmentedControl for sorting goals on gallery #89
Conversation
krugerk
added
STY
|
In keeping up with the previous discussion on sorting goals (MR #58), where it was decided the three lists of goals should not share a common sort but rather the sorting of goals on the gallery should be closer to what one sees on the website, a segmented control has been introduced to allow "sorting by tapping column headers". (Unrelated but still noticeable are the flickering graphs, noted as Bug #43.) |
|
GUI could use a bit of tweaking with dark appearance (#94 ) and/or on iOS 13 (with its different appearance for segmented controls - for example the visible color behind the rounded corners of the segmented control) |
|
I like this idea, I think we should get some user feedback about it. I want to get 5.7 released first and then we can put this into a 5.8beta and upload to TestFlight. |
|
If the sort pref only is for the gallery and we use this segmented control instead, then there need not be a separate screen just for picking the sort criteria. |
krugerk
added
needs tests
and removed
STY
- allow sorting of the goals directly from the gallery via the SegmentedControl - sort by preference is synced with one available in the app settings - can combine filtering (by slug) with quick sort via segmentedControl
Considering the sorting preference is used only on the gallery and the gallery now contains a segmented control to sort by the tap of a control (where one can also see the sort order used), a separate VC is not needed to setting the sorting order.
These are now computed properties.
When the user has not yet selected a preference, the gallery now explicitly sorts by deadline. This is done without setting the preference in UserDefaults as doing so indicates that the user set that option.
via the SegmentedControl
app settings