Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort goals consistently #58

Closed
wants to merge 4 commits into from
Closed

sort goals consistently #58

wants to merge 4 commits into from

Conversation

krugerk
Copy link
Contributor

@krugerk krugerk commented Jun 12, 2020

goals are sorted according to the sort-goals-by preference not only in the list displayed on the gallery but also in the lists displayed on configureNotifications and healthKitConfig

@krugerk krugerk changed the title Bugfix/sortgoals sort goals consistently Jun 13, 2020
krugerk added 4 commits June 15, 2020 22:27
goals are sorted alphabetically by slug
on HealthKitConfigVC and ConfigureNotificationsVC

this is now the same order used in
GalleryVC when sorting by slug
there is a preference for sorting goals and now
that preference works on the three screens
showing a list of the goals

previously only the main gallery respected
the preference with the other two
sorting by slug
@andrewpbrett
Copy link
Contributor

So I'm not positive that it makes sense to have the sort preference apply to goals in places besides the dashboard. I wouldn't expect a settings screen to order goals in a way that changes (or could change) from day to day. See, for example, the Reminders page on the website - https://www.beeminder.com/reminders/[username]. It does let you click any of the columns and sorts things in place, but that sort order is not persistent.

@krugerk
Copy link
Contributor Author

krugerk commented Jun 15, 2020

https://www.beeminder.com/[username] allows for sorting in the same way, by column in the same way as the reminders (which seems to default to sorting by slug) page does. However, it appears to sort by deadline upon login. And true, each are sorted independently.

We have the fix for the Z to A sorting on goal names in Commit 94b9c1e followed by Commit d474d26 where all three lists of goals are sorted in the same way.

This is the control the user has in the app to sort the goals. In my case, with my dozen or so goals, given the few times entering into the healthKitSettings screen, I was focused on finding the goal for which I wanted to add a HealthKit data source. The sort order was not clear to me though it did not much matter since I only needed to scroll just a bit.

I think using the same sort in these three cases adds value if not for anything other than being consistent and for providing the user with a chance to influence an outcome.

How shall we proceed?

@krugerk
Copy link
Contributor Author

krugerk commented Jun 15, 2020

This appears to be the original feature request for sorting by name in the app: https://forum.beeminder.com/t/feature-request-alphabetical-or-time-listing-on-iphone-app/324

@krugerk krugerk closed this Jun 29, 2020
@krugerk krugerk deleted the bugfix/sortgoals branch June 29, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants