Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/43 graph images flicker on gallery screen #103

Merged
merged 2 commits into from
Jul 30, 2020
Merged

Bugfix/43 graph images flicker on gallery screen #103

merged 2 commits into from
Jul 30, 2020

Conversation

krugerk
Copy link
Contributor

@krugerk krugerk commented Jul 29, 2020

No description provided.

@krugerk krugerk requested a review from andrewpbrett July 29, 2020 07:06
krugerk added 2 commits July 29, 2020 09:07
@krugerk
[#43] use goal's lastTouch for graph/thumbnail cache-busting URLs
bcbe190 
rather than using the current timestamp for each and every
request to the cache-busting version of the two urls, we
now rely on each goal's own lasttouch timestamp
@krugerk
[#43] use query parameter proctime for cache-busting url
6120e23 
previously the timestamp was being appended; now we use proctime, consistent
with how the urls are formatted on the website
@krugerk krugerk linked an issue Jul 29, 2020 that may be closed by this pull request
Graph images flicker on gallery screen #43
Closed
andrewpbrett
andrewpbrett approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@andrewpbrett andrewpbrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good; I tested it by adding a datapoint, via both the app and the website, and confirming that the graph updated on the app's gallery screen. The flicker is gone too. Thanks!

@andrewpbrett andrewpbrett merged commit b09ab23 into beeminder:master Jul 30, 2020
@krugerk krugerk deleted the bugfix/43-graph-images-flicker-on-gallery-screen branch July 31, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewpbrett andrewpbrett andrewpbrett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Graph images flicker on gallery screen
2 participants
@krugerk @andrewpbrett