Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support pull-to-refresh on goalVC #84

Closed
krugerk opened this issue Jul 5, 2020 · 2 comments · Fixed by #130
Closed

support pull-to-refresh on goalVC #84

krugerk opened this issue Jul 5, 2020 · 2 comments · Fixed by #130
Assignees
@krugerk
Labels
RFE Request For Enhancement aka feature request UVI Will count as a User-Visible Improvement

Comments

@krugerk
Copy link
Contributor

krugerk commented Jul 5, 2020

Pull-to-refresh is supported on the gallery VC. I think it would be more consistent to support pull-to-refresh on the goal VC as well. The refresh button in the navbar would no longer be needed.
@krugerk krugerk added RFE Request For Enhancement aka feature request UVI Will count as a User-Visible Improvement labels Jul 8, 2020
@krugerk
Copy link
Contributor Author

krugerk commented Jul 8, 2020

I see tapping the refresh button appears to just reload the graph rather than the goal (and subsequently its data). By pull-to-refresh, I was thinking 'fetch goal'.

@krugerk
Copy link
Contributor Author

krugerk commented Jul 31, 2020

Not quite a 'just' as in my previous comment because the call used apparently triggers the backend to create the graph again and should be used sparingly.

@krugerk krugerk self-assigned this Aug 8, 2020
@krugerk krugerk mentioned this issue Aug 10, 2020
Merged
andrewpbrett pushed a commit that referenced this issue Aug 31, 2020
@krugerk @andrewpbrett
fixes #84 - pull-to-refresh on goalVC
73ef002
@krugerk krugerk mentioned this issue Feb 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krugerk krugerk

Labels
RFE Request For Enhancement aka feature request UVI Will count as a User-Visible Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pull to refresh on goal vc
1 participant
@krugerk