pull to refresh on goal vc #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krugerk
commented
Aug 10, 2020
missed a few (the 'plain' ones) previously tackled the others in commit 94b5280
... avoiding a force unwrap
krugerk
commented
Aug 19, 2020
| self.syncHealthDataButtonPressed(numDays: 7) | ||
| } | ||
|
|
||
| private var previouslySeenSyncDayAmount: [Int] { |
| @@ -419,7 +421,7 @@ class GalleryViewController: UIViewController, UICollectionViewDelegateFlowLayou | |||
| self.present(alert, animated: true, completion: nil) | |||
| } | |||
| } | |||
| self.refreshControl.endRefreshing() | |||
| self.collectionView?.refreshControl?.endRefreshing() | |||
| MBProgressHUD.hideAllHUDs(for: self.view, animated: true) | |||
| self.collectionView!.reloadData() | |||
There was a problem hiding this comment.
collectionView? two lines earlier and collectionView! here?
be consistent
| @@ -373,7 +375,7 @@ class GalleryViewController: UIViewController, UICollectionViewDelegateFlowLayou | |||
| @objc func didFetchGoals() { | |||
| self.sortGoals() | |||
| self.setupHealthKit() | |||
| self.refreshControl.endRefreshing() | |||
| self.collectionView?.refreshControl?.endRefreshing() | |||
| MBProgressHUD.hideAllHUDs(for: self.view, animated: true) | |||
| self.collectionView!.reloadData() | |||
andrewpbrett
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #84
provides the scrollView with a refreshControl and configures the refreshControl to refresh (poll for the changes to the graph, then refresh the goal; same as before via the navBarItem) on valueChanged
removes the now redundant refresh navBarItem
little bit of 'clean code' around the code touched