-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix 477 timer shows goal name #481
Merged
theospears
merged 2 commits into
beeminder:master
from
krugerk:bugfix/477-timer-shows-goal-name
Oct 3, 2024
Merged
Bugfix 477 timer shows goal name #481
theospears
merged 2 commits into
beeminder:master
from
krugerk:bugfix/477-timer-shows-goal-name
Oct 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for making this fix. I also really appreciate you including a screenshot in the comment. I have a few requests before merging:
|
23a4262
to
4ca0a75
Compare
aa01de8
to
e9dbd00
Compare
e9dbd00
to
a178077
Compare
This was referenced Sep 30, 2024
@theospears the Merge Request has been split and the buttons adjusted. |
theospears
approved these changes
Oct 3, 2024
theospears
pushed a commit
that referenced
this pull request
Oct 4, 2024
Use a more consistent iOS styling for in app buttons. Example: <img width=400 src=https://github.com/user-attachments/assets/5e7c57e2-dcaf-46e1-92b4-fed9f3759370 /> See #481 (comment)
theospears
pushed a commit
that referenced
this pull request
Oct 5, 2024
clean code align some inconsistencies with providing a goal to some view controllers that required one See #481 (comment)
@krugerk those yellow-on-black buttons look very nice. thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #477 by displaying the name ("slug") of the goal on the timer view controller
screenshot:
![](https://private-user-images.githubusercontent.com/4656811/371459438-727bc44a-3405-4ed4-a22a-6ec1ae64480f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxMzY0NTUsIm5iZiI6MTczOTEzNjE1NSwicGF0aCI6Ii80NjU2ODExLzM3MTQ1OTQzOC03MjdiYzQ0YS0zNDA1LTRlZDQtYTIyYS02ZWMxYWU2NDQ4MGYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDlUMjEyMjM1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MDAxNzMzY2VkOGFiY2MxZDE1MDJiNWQzNDgxYjJmYTZhNTI0OWRkYWY1NGU4ODNmNThlMThiOGYzZDk3M2RhMSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.991ToH8VpN4utOOX9a7rMcy4DfBLuo7ZbQdWu8Ncqdc)