align some inconsistencies with providing a goal #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you update the PR to merge cleanly, now I have merged the test fixes in #481 |
krugerk
force-pushed
the
consistently-passing-in-required-goal
branch
from
6b1f217 to
6cf4b4e
Compare
theospears
approved these changes
Oct 4, 2024
|
Once again conflicting. Maybe consider using https://graphite.dev/ so you can open stacked PRs? |
align some inconsistencies with providing a goal to some view controllers that required one
krugerk
force-pushed
the
consistently-passing-in-required-goal
branch
from
6cf4b4e to
c02010b
Compare
updated |
Thanks for the tip. I have seen merge requests of yours referring to it. I will take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean code
align some inconsistencies with providing a goal
to some view controllers that required one
See #481 (comment)