Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetchart | tracks don't have cover, but beet says "...has album art" #1126

Closed
fohrums opened this issue Dec 1, 2014 · 7 comments
Closed
Labels
needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature."

Comments

@fohrums
Copy link

fohrums commented Dec 1, 2014

Using the fetchart plugin to grab an image fails, because it still thinks my tracks still has albumart when indeed it doesn't.

Ofcourse, I then made sure there was no coverart
$ beet clearart query
and then then re-checked the fetchart, but no luck.
$ beet fetchart query

reason is I issued a --force (generically websearch) parameter to grab an imediate image link.
$ beet fetchart -f query

Now I want to test fetchart's sources:, especially with itunes but I can't if beets say's that the query results already has an album art when there is none on the tag/directory

@sampsyo
Copy link
Member

sampsyo commented Dec 1, 2014

The clearart command removes embedded art, not associated files. Running fetchart with the -f flag should query your sources again. Can you expand on what goes wrong with beet fetchart -f now?

@sampsyo sampsyo added the needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature." label Dec 1, 2014
@fohrums
Copy link
Author

fohrums commented Dec 2, 2014

because fetchart indicates that the query has album art I needed to remove the embeded/physical image. BTW, I don't personally keep anything else besides music files in my music library directory.

@sampsyo
Copy link
Member

sampsyo commented Dec 3, 2014

Sorry, I should have been more explicit—what does the command output?

When I run it, even twice in a row:

$ beet fetchart -f
Aesop Rock - None Shall Pass: found album art
$ beet fetchart -f
Aesop Rock - None Shall Pass: found album art

it fetches new art each time, even though the album already has an image associated.

@fohrums
Copy link
Author

fohrums commented Dec 5, 2014

So, even though my query has no coverart embeded or in directory, beet still can't fetch art as it mentions it still has an album art.

I've removed coverart for this one album, then attempted to fetchart after removal, but failed as it reports saying still 'has album art'.

$ beet clearart album: III
Clearing album art from items:
BADBADNOTGOOD - Triangle
BADBADNOTGOOD - Can't Leave the Night
BADBADNOTGOOD - Kaleidoscope
BADBADNOTGOOD - Eyes Closed
BADBADNOTGOOD - Hedron
BADBADNOTGOOD - Differently, Still
BADBADNOTGOOD - Since You Asked Kindly
BADBADNOTGOOD - CS60
BADBADNOTGOOD - Sustain
BADBADNOTGOOD feat. Leland Whitty - Confessions
$ beet fetchart album: III
BADBADNOTGOOD - III: has album art

There is no coverart in the directory aswell.

$ ls -all
total 344232
drwxrwxrwx 1 root root 4096 Dec 1 20:55 .
drwxrwxrwx 1 root root 0 Dec 1 20:38 ..
-rwxrwxrwx 1 root root 25609485 Dec 1 21:09 01-01 Triangle.flac
-rwxrwxrwx 1 root root 29453785 Dec 1 21:09 01-02 Can't Leave the Night.flac
-rwxrwxrwx 1 root root 32617426 Dec 1 21:09 01-03 Confessions.flac
-rwxrwxrwx 1 root root 48488938 Dec 1 21:09 01-04 Kaleidoscope.flac
-rwxrwxrwx 1 root root 37144117 Dec 1 21:09 01-05 Eyes Closed.flac
-rwxrwxrwx 1 root root 36326432 Dec 1 21:09 01-06 Hedron.flac
-rwxrwxrwx 1 root root 29699646 Dec 1 21:09 01-07 Differently, Still.flac
-rwxrwxrwx 1 root root 29768000 Dec 1 21:09 01-08 Since You Asked Kindly.flac
-rwxrwxrwx 1 root root 43514948 Dec 1 21:09 01-09 CS60.flac
-rwxrwxrwx 1 root root 39848177 Dec 1 21:09 01-10 Sustain.flac

(please remove this 'parenthesized' text and add the appropriate markdown syntax to emphasize code, I couldn't have avoided it to be in paragraph form)

@sampsyo
Copy link
Member

sampsyo commented Dec 5, 2014

As I explained above, you do not need to run clearart, but you do need to use the -f flag with fetchart. What happens when you run that?

@fohrums
Copy link
Author

fohrums commented Dec 6, 2014

@sampsyo the -f flag checks some web-source i'm actually not sure of and it's always the same image too regardless of my sources: order.

I know this, becuase I set my sources: itunes only and it still pulls that web-source image instead as it's completely different from the itunes album page.

According to the wiki:
"...(-f flag) searches for art in Web databases regardless (of sources)"

@sampsyo
Copy link
Member

sampsyo commented Dec 6, 2014

The -f flag searches your configured source list (including iTunes).

If you're suspicious that the plugin isn't searching the right sources, you can try verbose mode to see if there are any clues:

$ beet -v fetchart -f

reiv added a commit to reiv/beets that referenced this issue Nov 1, 2015
reiv added a commit that referenced this issue Nov 2, 2015
reiv added a commit that referenced this issue Nov 2, 2015
@reiv reiv closed this as completed in 269d0e5 Nov 2, 2015
reiv added a commit that referenced this issue Nov 2, 2015
Fix #1126: Check if album art file actually exists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature."
Projects
None yet
Development

No branches or pull requests

2 participants