Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1126: Check if album art file actually exists #1682

Merged
merged 3 commits into from
Nov 2, 2015
Merged

Conversation

sampsyo
Copy link
Member

@sampsyo sampsyo commented Nov 2, 2015

Part of #1679 by @reiv.

This can be reproduced by simply deleting cover.jpg (or equivalent album art file) and then running beet fetchart. With this change, when invoking fetchart as a command, it will also check if the actual file given by artpath exists in that directory.

@sampsyo
Copy link
Member Author

sampsyo commented Nov 2, 2015

This one is obviously the most straightforward of the three, and a good idea regardless of the eventual diagnosis of #1679. A test would be nice, and we also need a changelog entry, but beyond that this is ready.

@reiv
Copy link
Contributor

reiv commented Nov 2, 2015

Added a simple test. Is this sufficient?

@sampsyo
Copy link
Member Author

sampsyo commented Nov 2, 2015

Looks perfect to me; thanks! Feel free to hit that green button if you like.

reiv added a commit that referenced this pull request Nov 2, 2015
Fix #1126: Check if album art file actually exists
@reiv reiv merged commit f891184 into master Nov 2, 2015
@sampsyo
Copy link
Member Author

sampsyo commented Nov 2, 2015

Lovely! Thanks again. ✨

@reiv reiv deleted the 1126-deleted-art branch November 4, 2015 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants