-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lyrics: Review my patch please! #1953
Comments
Thanks for looking into this! I'm a little confused about the need for 607f41b where the And we apparently added an undocumented dependency on BeautifulSoup for the LyricsWiki backend in #1912. It would be awesome to avoid needing BS for such a simple scraping task (as we did before). @jackwilsdon, any thoughts on whether |
The idea behind the second commit was:
|
So, should that be done in |
Aha! Late-night coding has gotten me before too. 😇 Doing the check in |
I believe it's needed due to to the way LyricsWiki formats their lyrics. I'll take a look at refactoring Here's what the unescaped lyrics look like (with added indentation): <div class='lyricbox'>
I guess I should've known by the way you parked your car sideways<br />
That it wouldn't last<br />
See, you're the kinda person that believes in makin' out once<br />
Love 'em and leave 'em fast<br />
I guess I must be dumb 'cause you had a pocket full of horses<br />
Trojan and some of them used<br />
But it was Saturday night, I guess that makes it all right<br />
And you say - "What have I got to lose?"<br />
<br />
...
<br />
Little red Corvette, oh
<!--
<p>
NewPP limit report
Preprocessor node count: 857/300000
Post‐expand include size: 6188/2097152 bytes
Template argument size: 1451/2097152 bytes
Expensive parser function count: 1/100
ExtLoops count: 2/100
</p>
-->
<div class='lyricsbreak'></div>
</div> |
If it's just a matter of converting |
Aha, I didn't know we already had some expressions for those. I'll take a look. |
Just opened #1956 with a fix, it seems we can use |
Let's call this good as of #1956. |
reopening, the failing langdetect import is still ongoing |
What exactly is the issue, @Kraymer? Does the |
@jackwilsdon yep that's it #1963 |
Yesterday I did this
271f7c8...607f41b
because my imports were breaking (i.e. with a traceback) halfway-through. I don't know the lyric plugin's code, though. So it might be good if someone who does had a look at it.
Maybe these checks should be at top-level and would let the plugin issue a warning already on initialization if any of the activated sources need
beautifulsoup4
orlangdetect
?The text was updated successfully, but these errors were encountered: