Add lyrics translation using Microsoft Bing API #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By subscribing to Microsoft Translator API, one can now activate the translation of lyrics from one set of source langages to a target langage. Translations are appended to each original sentence using ‘/‘ as separator.
| @@ -113,3 +121,19 @@ After that, the lyrics plugin will fall back on other declared data sources. | |||
|
|
|||
| .. _pip: http://www.pip-installer.org/ | |||
| .. _BeautifulSoup: http://www.crummy.com/software/BeautifulSoup/bs4/doc/ | |||
|
|
|||
| Activate on-the-fly translation | |||
There was a problem hiding this comment.
Matching our usual style, this should probably be in Title Case: "Activate On-the-Fly Translation"
|
This is pretty nifty! I'm all for it—it's a fairly "niche" feature, but that's true of a great many of beets' features. 😃 |
Bing API has a limit of 2M chars/month. It’s common to have repeating sentences in lyrics so to reduce number of chars sent per song, store sentences in a set and send it, instead of sending the whole lyrics.
|
👻 Good to merge? |
|
Looks great! Go for it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌐 Adiou,
Dunno if it should be merged or if I should maintain it separately in my fork : scratching my own hitch here, and the result of translation can be suboptimal.
setto reduce size of text to translate and thus translate more songs within the fixed API limit of 2,000,000 chars/month[...]