-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable plugin options requiring a missing dependency #1963
Comments
It would be cool if plugins themselves could tell beets core about the issue and beets would disable the plugin automatically. I wonder if this is possible? |
maybe with |
This is exactly what beets already does (see https://github.com/beetbox/beets/blob/master/beets/plugins.py#L267 which also catches any |
adding something like this at the top would work / is too hacky? try:
import langdetect
except ImportError:
disable_source('bing')
warn_user() |
The warning should not print when the source is not enabled through the config, though, as that combination may aswell be intentional. Have a look at |
Fixed in #1968 |
lyrics: clean up import handling and source removal (Fixes #1963)
When a library related to a plugin option (langdetect for translate, bs4 for google lyrics backend, etc) is missing, it should be detected at the plugin init and the offending option should be disabled with a message printed once pointing to the docs.
Currently we have an error/warning for each song.
The text was updated successfully, but these errors were encountered: