More helpful message than "moving 0 albums"

[RollingStar]

Problem

When running beet mv, beets filters the move job to remove any move operations that have the same source and destination. But this can be unintuitive: albums will show up in "beet ls" then vanish when you run "beet mv".

beets/beets/ui/commands.py

Line 1485 in 9556ab3

def move_items(lib, dest, query, copy, album, pretend, confirm=False,

λ beet ls -a Bad
Michael Jackson - Bad
“Weird Al” Yankovic - Bad Hair Day

λ beet mv -p -a Bad
Moving 0 albums.

λ beet mv -a Bad
Moving 0 albums.

Proposed Solution

Save the results of objs into something like orig_objs and compare it to objs after the filter operation is complete. The new output message could be something like:

Moving 0 albums (found 2 with same source/destination)

[sampsyo]

Good call; this would be a useful thing to print.

[RollingStar]

master...RollingStar:verbose-move

Here it is in action, with different output depending on if there are any objects filtered out.

λ beet mv -a bad                                          
Moving 0 albums (found 3 with same source & destination). 

λ beet mv -a bad                                          
Moving 3 albums.                                          

λ beet mv jackson                                         
Moving 71 items (found 11 with same source & destination).

λ beet mv jackson                                         
Moving 82 items.                                          

λ beet mv -a weird al                                     
Moving 1 album (found 15 with same source & destination). 

I think I have some work to do on my forked repo to not make this change have six git commits attached to it. Then I can submit a PR.

[sampsyo]

Awesome! Thank you!!

May I suggest some slightly simpler wording: for example, “15 already in place”?

[RollingStar]

Good idea.

#3120