Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to clear all fields before applying a match #934

Closed
ecdlguy opened this issue Sep 8, 2014 · 4 comments
Closed

Option to clear all fields before applying a match #934

ecdlguy opened this issue Sep 8, 2014 · 4 comments
Labels
feature features we would like to implement

Comments

@ecdlguy
Copy link

ecdlguy commented Sep 8, 2014

An option/plugin to use only metadata from online sources.

  1. Don't import any of the files original tag data to the beets-database, only use this information to obtain matches from the online sources.
  2. Completely clear/delete the entire existing tag before writing the new one.
@sampsyo sampsyo changed the title Use existing tag data solely for match finding Option to clear all fields before applying a match Sep 8, 2014
@sampsyo sampsyo added the feature features we would like to implement label Sep 8, 2014
@sampsyo
Copy link
Member

sampsyo commented Sep 8, 2014

This should be fairly straightforward to add. My only reservation is that it may not actually be what you (or most people) want, since metadata indices can sometimes be missing data.

@ecdlguy
Copy link
Author

ecdlguy commented Sep 8, 2014

Yes, you're right that this can lead to a loss of information in case of relatively well tagged mp3s. For my particular music collection however, it'd be a lot better to have some data missing than to leave the horrible tag content existing in many of my files.
I'd be very happy to have this option!

@l-t-k
Copy link
Contributor

l-t-k commented Jan 25, 2015

#1173 This would be nice!

@tummychow
Copy link
Contributor

I am very interested in implementing this, as the current metadata on my music collection is hot garbage. The genre tag is particularly problematic because musicbrainz doesn't set it, so I end up importing whatever genre was already tagged on the track. I'd much prefer beets to be the originator for all the tags that end up on my imported music.

I'd like to confirm my understanding of the problem before I work on a PR:

  • the changes should be made in the apply_metadata function here or somewhere in the callchain leading there (ImportTask.apply_metadata is around where I'm thinking).
  • to achieve the desired effect, every field in the Item should be zeroed before applying the matched metadata. This zeroing should only happen if the user actually chooses apply.
  • a new configuration option (import.from_scratch) should be added to toggle the behavior globally, with a corresponding flag (--from-scratch) to toggle the behavior at runtime. Anyone want to bikeshed on the name of this?
  • I need to add tests for all new functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature features we would like to implement
Projects
None yet
Development

No branches or pull requests

4 participants