-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement from_scratch option #2755
Conversation
Ping on this? @sampsyo ? |
That looks good to me, although I'll let @sampsyo have the final call 😂 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic! Thank you! I only found one tiny typo, which I can fix when I do the merge.
~~~~~~~~~~~~ | ||
|
||
Either ``yes`` or ``no`` (default), controlling whether existing metadata is | ||
discarded when a match is applied. This corresponds to the ``-from_scratch`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny typo: missing one dash in the option name.
Sorry for the long delay in reviewing this! Thanks for waiting while it got to the top of my list. This looks great: it's simple and it matches what users have been asking for. While we're here, I want to briefly take stock of all the ways we have for "clearing out metadata," which have grown steadily:
Some users might want to configure both It might be worth documenting this set of choices centrally somewhere, if anyone has a bright idea about where this should live. |
Merged! ✨ Thank you again for the clean, simple implementation and the readable documentation. |
My pleasure, thank you for merging. For myself, I actually use all three of scrub, zero, and from_scratch (zero for music that I import as-is, where from_scratch wouldn't apply). I personally think the detailed documentation on scrub/zero is sufficient for me to understand what they do and why I would want them, but my perspective might be skewed after thinking about and implementing this feature. |
Okay well, I asked for advice in #934, but I accidentally implemented it before getting an answer. Whoops!
Feel free to criticize style, implementation details, naming, tests/lack thereof, etc.