Fix discogs disc field is set to zero #1691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #587. The disc field is only zero when there is only one medium, so I think this will do the trick. I wasn't able to reproduce the real problem within the code. This is just a small workaround.
|
Thanks for finding the issue. Since discogs doesn't have tests, we need to be sure this doesn't break other situations. Obviously, the ideal solution would be to write some tests for this code. Barring that, maybe we can come up with a more fix—specifically, we should explain why the |
| @@ -299,6 +299,7 @@ def get_tracks(self, tracklist): | |||
| medium_count += 1 | |||
There was a problem hiding this comment.
Theoretically, this should be taking care of making the medium count 1.
This was referenced Oct 10, 2016
Merged
|
Closing this pull request after adding tests at #2228 - thanks @kooimens for providing the actual solution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #587. Disc field is only zero when there is only one medium, so this will do the trick. I wasn't able to reproduce the real problem within the code. This is just a small workaround.