discogs: set track.medium correctly for single medium albums
#2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add three tests for the setting of tracks' medium and medium_total on the discogs plugin. test_parse_medium_numbers_single_medium is meant to fail due to beetbox#587.
Fixes beetbox#587. The disc field is only zero when there is only one medium, so I think this will do the trick. I wasn't able to reproduce the real problem within the code. This is just a small workaround.
|
Very nice. With these tests, I'm convinced! |
|
Awesome, I'm glad the tests are persuasive enough! 🍸 Would anything else be required for this fix, or on the contrary would it be ok to merge it (and cleanup the related issue and the previous PR)? |
|
Nope! I say go ahead and merge at will. |
|
Excellent! Merging then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests mean to carry on the job by @kooimens at the open pull request #1691, adding some tests and an updated changelog. I cherry-picked the commit from kooimens in order to preserve credit.
As hinted on #2222, the problem was that
medium_countwas correctly increased whenever a new medium was detected on the main loop, but for albums with only one medium that increase did not take place, ending up with atrack.medium = 0.