Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4080 #4085

Merged
merged 9 commits into from
Oct 5, 2021
Merged

Fix #4080 #4085

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c4f2fff
Fix #4080
arogl Oct 2, 2021
b935346
changelog
arogl Oct 2, 2021
39def81
Fix lint error
arogl Oct 2, 2021
ade9978
Updated after feedback from @wisp3rwind
arogl Oct 2, 2021
a8b8d05
Update comment around Discogs-ID
arogl Oct 3, 2021
db0431d
Updated as per feedback from @wisp3rwind
arogl Oct 4, 2021
f7539b3
Update to extract regex testing from album_for_id
arogl Oct 4, 2021
109f4fa
Add tests for range of discogs id extraction
arogl Oct 4, 2021
b880e2d
Final clean up
arogl Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion beetsplug/discogs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,11 @@ def album_for_id(self, album_id):
# of an input string as to avoid confusion with other metadata plugins.
# An optional bracket can follow the integer, as this is how discogs
# displays the release ID on its webpage.
match = re.search(r'(^|\[*r|discogs\.com/.+/release/)(\d+)($|\])',
# Issue #4080 highlighted that Discogs changed the way the URL
# is formed
match = re.search(r'(^|[*r|discogs\.com/.+/release/])(\d+)($|)',
wisp3rwind marked this conversation as resolved.
Show resolved Hide resolved
album_id)

if not match:
return None
result = Release(self.discogs_client, {'id': int(match.group(2))})
Expand Down
3 changes: 3 additions & 0 deletions docs/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ Bug fixes:
* :doc:`/plugins/lyrics`: Fix crash bug when beautifulsoup4 is not installed.
:bug:`4027`

* :doc:`/plugins/discogs`: Fix regex for new style of regex.
wisp3rwind marked this conversation as resolved.
Show resolved Hide resolved
:bug: `4080`

1.5.0 (August 19, 2021)
-----------------------

Expand Down