Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to lyrics scrapers #4229

Merged
merged 3 commits into from
Jan 11, 2022
Merged

Conversation

ybnd
Copy link
Contributor

@ybnd ybnd commented Jan 10, 2022

Description

Fixes #4228, #4161

Used to include some non-lyrics content in the lyrics, see e.g. https://www.tekstowo.pl/piosenka,au_revoir_simone,crazy.html

To Do

  • Documentation. (If you've add a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst near the top of the document.)
  • Tests. (Encouraged but not strictly required.)

@ybnd
Copy link
Contributor Author

ybnd commented Jan 10, 2022

Should probably check whether this applies to all Tekstowo.pl lyrics pages

@sampsyo
Copy link
Member

sampsyo commented Jan 10, 2022

Awesome; thanks for the quick fix! Yeah, would you mind running this on a collection of songs in your library to confirm that the scraped lyrics are looking right?

@ybnd ybnd changed the title Make Tekstowo scraper more specific Minor fixes to lyrics scrapers Jan 10, 2022
@ybnd
Copy link
Contributor Author

ybnd commented Jan 10, 2022

  • Tested with some more examples, no issues as far as I could see
  • During testing I noticed a similar issue with the Genius backend (some footer junk got included in the lyrics), fixed that as well + updated changelog entry

@sampsyo
Copy link
Member

sampsyo commented Jan 11, 2022

Awesome; this looks fantastic. Thanks again for trying it out!!

@sampsyo sampsyo merged commit b310041 into beetbox:master Jan 11, 2022
@woodruffw
Copy link

Would it be possible to get a release with these changes? I also observed this locally 🙂

@yassernasc
Copy link

well.. the last official release is 1.6.0 and it was launched on 2021, the release note from that version says: "This release is our first experiment with time-based releases! We are aiming to publish a new release of beets every 3 months."

Err.. I am very bad estimating my schedules so I can't judge much :p

@xeruf
Copy link

xeruf commented Jun 22, 2024

Yeah still get Tekst piosenki, making no release for 3 years is really a bit silly :/
Ah nevermind, 2.0 is not pacakged for arch yet, odd...

@Serene-Arc
Copy link
Contributor

Unfortunately neither I nor any of the other managers are maintainers for the Arch project, so we can't update the beets package in the official repositories. There is, however, an AUR package, beets-git, that builds directly from our master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lyrics: Polish comments appear in text of lyrics
6 participants