Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Tekstowo extraneous text from lyricstext.yaml to fix test_lyrics #4344

Merged
merged 1 commit into from
May 5, 2022
Merged

Remove Tekstowo extraneous text from lyricstext.yaml to fix test_lyrics #4344

merged 1 commit into from
May 5, 2022

Conversation

qcasey
Copy link
Contributor

@qcasey qcasey commented May 5, 2022

Description

Fixes #4334

3f896ab fixed the plugin lyrics for Tekstowo. However the current test suite expects the extraneous text, which is why it's failing.

This PR removes the extraneous text from this particular song's definition.

beets/test/rsrc/lyricstext.yaml

Lines 57 to 62 in e52b598

u_n_eye: |
let see cool bed for sometimes are place told in yeah or ride open hide blame knee your my borders
perfect i of laying lies they love the night all out saying fast things said that on face hit hell
no low not bullets bullet fly time maybe over is roof a it know now airplane where tekst and tonight
brakes just waste we go an to you was going eye start need insane cross gotta historia mood life with
hurts too whoa me fight little every oh would thousand but high tekstu lay space do down private edycji

To Do

  • Documentation. (If you've add a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst near the top of the document.)
  • Tests. (Encouraged but not strictly required.)

@qcasey qcasey changed the title Remove Tekstowo extraneous text from lyricstext.yaml Remove Tekstowo extraneous text from lyricstext.yaml to fix test_lyrics May 5, 2022
@qcasey
Copy link
Contributor Author

qcasey commented May 5, 2022

Changing "first" and "second" in the following lines to "expected" and "result" would have made this error more apparent, I think.

beets/test/test_lyrics.py

Lines 248 to 249 in e52b598

f" Words only in first {keywords - words!r},"
f" Words only in second {words - keywords!r}."

@wisp3rwind
Copy link
Member

Good catch! I opened the other issue in response to the comments in #4228, but looking at that again, I can't tell whether @hlubach was actually running the latest development version. So, probably there was no issue beyond what #4229 already fixed.

Changing "first" and "second" in the following lines to "expected" and "result" would have made this error more apparent, I think.

Any chance you could open a PR for this?

@wisp3rwind wisp3rwind merged commit 9b027ae into beetbox:master May 5, 2022
@wisp3rwind wisp3rwind mentioned this pull request May 5, 2022
Closed
@qcasey qcasey mentioned this pull request May 5, 2022
Merged
3 tasks
@qcasey
Copy link
Contributor Author

qcasey commented May 5, 2022

Thanks! I agree, I can't find any issue with the lyrics in my Tekstowo tracks.

Any chance you could open a PR for this?

Sure, done #4345

@qcasey qcasey deleted the qcasey-patch-1 branch May 5, 2022 22:38
@hlubach
Copy link

hlubach commented May 6, 2022 via email

@hlubach
Copy link

hlubach commented May 6, 2022

Now I got a little bit lost
For as far I can see beet lyrics , will still give the text Piosenki etc.
To know it for sure I run Beet lyrics -f with the same result I think i use the latest version of Beets
Or is there an other then the master

@wisp3rwind
Copy link
Member

Now I got a little bit lost For as far I can see beet lyrics , will still give the text Piosenki etc. To know it for sure I run Beet lyrics -f with the same result I think i use the latest version of Beets Or is there an other then the master

No, there's no other relevant branch except for master. Did you actually install from source, as explained at https://beets.readthedocs.io/en/stable/faq.html?highlight=master#run-the-latest-source-version-of-beets? What I meant above is that that's not really stated in the other thread. If you did indeed, it would be great to know a specific song that exhibits this issue; otherwise we can't really track down what the problem might be.

@hlubach
Copy link

hlubach commented May 6, 2022 via email

@hlubach
Copy link

hlubach commented May 6, 2022 via email

@wisp3rwind
Copy link
Member

I installed this one pip install https://github.com/beetbox/beets/tarball/master

That should indeed be the latest version (at the time you installed it).

example after impoting

The example seems to be missing from your reply? In any case, what we really need to know is the URL for a problematic song on tekstowo. Just the end result without knowing where the incorrect lyrics came from is unfortunately not very useful.

@hlubach
Copy link

hlubach commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tekstowo lyrics source needs to be adapted to new website layout
3 participants
@qcasey @wisp3rwind @hlubach