-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add app verification tests for Linux system packages. #14
Conversation
b755544
to
ceb9464
Compare
ceb9464
to
361b840
Compare
This probably needs a re-review, because I've had to make a couple of changes. Firstly, I've added a separate "Debian" and "Ubuntu" test, with the "Ubuntu" test running locally, but only if the Python version is 3.10 (which is the version that matches the system python). More notably, I've dramatically downsized the test matrix. In this repo, a CI check like |
f9b3d2c
to
7de3231
Compare
7de3231
to
a72699c
Compare
@rmartin16 Ok - finally got it working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. However, this approach does require callers to understand that app-build-verify
requires a python-version
input and that the python-version
value is coherent with the ubuntu version being tested so that a "local linux system build" is actually tested; otherwise, the test is silently omitted. This can be managed (especially since you review all PRs) but it's perhaps a bit un-obvious. I'll defer to you if this subtlety is acceptable.
Yeah - I completely agree that this is a weakness. However, we have very limited controls here - we either fail a CI run, or we pass it (I guess there's experimental/non-critical fail as well, but that's not really a helpful signal). |
Add Linux system package builds to the verification pipeline.
Adds 3 new app verification targets:
The packaging steps have been disable (for now) because Briefcase doesn't support them. They should be enabled once beeware/briefcase#1063 and beeware/briefcase#1064 have been completed.
Refs beeware/briefcase#1106.
PR Checklist: