Ensure that Briefcase runs a CI pass on System packages. #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmartin16
approved these changes
Mar 9, 2023
There was a problem hiding this comment.
I created beeware/.github#21 to avoid PySide2 RPM builds for all repos since fedora is already using Python 3.11 in release 37.
Do you still want to disable PySide2 builds on Ubuntu here for Briefcase? The builds are still possible on Ubuntu 22.04 but I'm fine either way.
mhsmith
approved these changes
Mar 9, 2023
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time #1106 landed, the .github configuration didn't include System package builds in the CI configuration (Refs beeware/.github#14).
This makes the tweak necessary to ensure that system packages builds will pass.
PR Checklist: