-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shove the whole codebase through Prettier #513
Conversation
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
==========================================
- Coverage 83.55% 83.52% -0.03%
==========================================
Files 171 171
Lines 5400 5403 +3
Branches 1 1
==========================================
+ Hits 4512 4513 +1
- Misses 888 890 +2
Continue to review full report at Codecov.
|
Generated by 🚫 dangerJS |
[ESLint issue will be fixed in a separate PR...] |
This PR makes Bemuse use Prettier’s code formatting style instead of using Standard. Other Standard rules (that has to do with common errors) stay intact though, but stylistic issues are now governed by Prettier.
Rationale:
Recently there are weird cases when prettier-eslint sometimes fail on ESLint step, and causes the source file to be formatted using only Prettier. Rather than fiddling with these tools to get the code to be compliant with Standard, I decided to use only Prettier to handle stylistic issue now.
Prettier supports more languages and results in more consistent formatting. (YAML, JSON, and SCSS files are now formatted using Prettier in this PR.)
Tasks:
Set up Prettier
Remove prettier-eslint
Update docs
Bring back style checking into Danger