Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eslint issues #517

Merged
merged 4 commits into from
Dec 8, 2018
Merged

Fix eslint issues #517

merged 4 commits into from
Dec 8, 2018

Conversation

dtinth
Copy link
Member

@dtinth dtinth commented Dec 8, 2018

This PR

  • Removes remaining ESLint failures warnings in Shove the whole codebase through Prettier #513

    • Except: “packages/bemuse-tools/src/server.js line 6 – Unable to resolve path to module 'rx'. (import/no-unresolved)” — somehow Yarn does not install it?!?!?!
  • Removes the lint Gulp task and replace with a direct call to ESLint CLI.

@codecov-io
Copy link

codecov-io commented Dec 8, 2018

Codecov Report

Merging #517 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #517   +/-   ##
=======================================
  Coverage   83.52%   83.52%           
=======================================
  Files         171      171           
  Lines        5403     5403           
  Branches        1        1           
=======================================
  Hits         4513     4513           
  Misses        890      890

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ef5f57...6cb6877. Read the comment docs.

@dtinth dtinth merged commit ae2b6f8 into master Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants