Port _SixMetaPathImporter to Python 3.10 #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failure in CI is caused by the typing module which is not compatible with Python 3.3 but all other tests look good. I can also confirm that this patch works well with Python 3.10 and fixes all tests previously failing due to the warning. We are already testing this patch in Fedora and I can confirm that more than a hundred packages are okay with it with Python 3.9. |
|
LGTM, but I don't have a lot of context around it. |
brettcannon
approved these changes
Dec 14, 2020
|
Because this is such a weird loader the patch LGTM as a way to make it function appropriately. |
|
I can confirm that more than 5 hundred RPM packages build fine with six with this patch. |
|
@benjaminp: Thanks for the update. Tests still pass ;-) |
|
Thanks for the merge :-) |
benjaminp
added a commit
that referenced
this pull request
Apr 4, 2021
1 task
This was referenced Aug 10, 2021
taratatach
added a commit
to cozy/cozy.github.io
that referenced
this pull request
Mar 12, 2024
`mkdocs` v1.2.0 makes use of `ghp_import` v2.1.0 which in turn makes use of `dateutil` which makes use of the `six.moves` module. The way this module is generated in `six` v1.11.0 is not compatible with Python 3.10+. This gets fixed in v1.16.0 (see benjaminp/six#343).
taratatach
added a commit
to cozy/cozy.github.io
that referenced
this pull request
Mar 13, 2024
`mkdocs` v1.2.0 makes use of `ghp_import` v2.1.0 which in turn makes use of `dateutil` which makes use of the `six.moves` module. The way this module is generated in `six` v1.11.0 is not compatible with Python 3.10+. This gets fixed in v1.16.0 (see benjaminp/six#343).
taratatach
added a commit
to cozy/cozy.github.io
that referenced
this pull request
Mar 13, 2024
`mkdocs` v1.2.0 makes use of `ghp_import` v2.1.0 which in turn makes use of `dateutil` which makes use of the `six.moves` module. The way this module is generated in `six` v1.11.0 is not compatible with Python 3.10+. This gets fixed in v1.16.0 (see benjaminp/six#343).
taratatach
added a commit
to cozy/cozy.github.io
that referenced
this pull request
Mar 13, 2024
`mkdocs` v1.2.0 makes use of `ghp_import` v2.1.0 which in turn makes use of `dateutil` which makes use of the `six.moves` module. The way this module is generated in `six` v1.11.0 is not compatible with Python 3.10+. This gets fixed in v1.16.0 (see benjaminp/six#343).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #341.