Avoid deprecation warning on CPython 3.9 #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch! According to the doc, we could even skip it starting with Python 3.7, right? |
bstaletic
force-pushed
the
master
branch
2 times, most recently
from
35c4b8e
to
f9d10b0
Compare
True. The tests seem to pass. The failure on python 3.10 is related to benjaminp/six#343 and isn't caused by my PR. |
|
Do you mind adding a comment in the code and a link to the doc? |
bstaletic
force-pushed
the
master
branch
2 times, most recently
from
7d7c0e3
to
09e44ea
Compare
|
Changelog entry and comment added. |
Since CPython 3.7 `PyEval_InitThreads()` does nothing and the function has been deprecated since CPython 3.9.
BoboTiG
approved these changes
Jan 6, 2021
|
Thanks a lot @bstaletic :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the docs, we should just skip this call.